The restore command should not write any assets itself, everything should be written when the RestoreResult is committed #3261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkolev92
requested review from
aortiz-msft,
cristinamanum,
dominoFire,
donnie-msft,
dtivel,
heng-liu,
kartheekp-ms,
rrelyea,
zivkan and
zkat
as code owners
jeffkl
reviewed
Feb 24, 2020
nkolev92
changed the title
|
Update: This is the right fix long term and will go into 5.6 eventually. |
dtivel
approved these changes
Feb 24, 2020
donnie-msft
approved these changes
Feb 24, 2020
test/NuGet.Core.Tests/Microsoft.Build.NuGetSdkResolver.Tests/RestoreRunnerExTests.cs
Outdated
Show resolved
Hide resolved
nkolev92
force-pushed
the
dev-nkolev92-restoreResultCleanup
branch
from
fb604d7
to
c258545
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#8793
Regression: Yes
Fix
Details: When restore is run without a commit, it should not generate any assets.
This caused a permissions problem with the resolver on linux where, because the temp folder is machine-wide while the restore process was running without admin permissions.
Note that this is a regression and ideally is reviewed with high priority :)
Testing/Validation
Tests Added: Yes
Reason for not adding tests:
Validation: