Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supplied by platform design #13634

Draft
wants to merge 7 commits into
base: dev
Choose a base branch
from
Draft

Conversation

nkolev92
Copy link
Member

WIP: Not ready to be reviewed by anyone beyond an immediate group.

Prototype in https://github.com/NuGet/NuGet.Client/tree/dev-nkolev92-suppliedByPlatform
Related: NuGet/NuGet.Client#5919

To get dummy values from prototype, set AddDummyPrunedPackageReferences to true.

Copy link

@dsplaisted dsplaisted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't look like the spec explicitly states whether pruned packages will be downloaded at all. It would be good to explicitly never download pruned packages. Some vulnerability scanners look at the global packages folder, so this would ensure that those scanners wouldn't have false positives for pruned packages.

accepted/2024/supplied-by-platform.md Outdated Show resolved Hide resolved
@nkolev92
Copy link
Member Author

It doesn't look like the spec explicitly states whether pruned packages will be downloaded at all. It would be good to explicitly never download pruned packages. Some vulnerability scanners look at the global packages folder, so this would ensure that those scanners wouldn't have false positives for pruned packages.

Apparently I only had that in the summary.

This helps avoid downloading unnecessary reference and implementation packages

I'll add that explicitly in the rest of the spec as well.

@nkolev92
Copy link
Member Author

Pushed some more changes to the spec based on the feedback.
There is a limitation with transitive shared frameworks. Not sure if we have an automatic solution for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants