Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create proposal to replace blue checkmark #13573

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Conversation

albarry4
Copy link
Contributor

@albarry4 albarry4 commented Jun 24, 2024

@albarry4 albarry4 requested a review from a team as a code owner June 24, 2024 20:25
@albarry4 albarry4 marked this pull request as draft June 24, 2024 20:31
@donnie-msft
Copy link
Contributor

👀 does this also apply to Client?

@albarry4
Copy link
Contributor Author

albarry4 commented Jun 24, 2024

👀 does this also apply to Client?

@donnie-msft yes! this would apply anywhere the current blue checkmark is shown

@JonDouglas
Copy link
Contributor

JonDouglas commented Jun 25, 2024

Wonderful proposal!

Another consideration is not needing any type of iconography and just create the status as a pill/badge HTML element that just says Prefix Reserved

One icon that comes to mind though is a tag + lock, which conveys the idea of a name/id & reserved/locked. But that may compete with the existing tagging functionality.

image

This could sit next to upcoming work revolving around build provenance which will have this type of icon:
image

i.e. Forgive my 5 second mockup here:

image

or

image

@albarry4 albarry4 marked this pull request as ready for review June 27, 2024 16:40
@albarry4 albarry4 requested a review from a team June 27, 2024 16:40
@albarry4
Copy link
Contributor Author

@JonDouglas I really like the other icon that you proposed, I would definitely like to add that to the discussion of potential icons. I do, however, see the potential for people to associate it with the existing tags concept on NuGet mistakenly. Perhaps some customer research could be done here about the icon options?

I did consider the idea of doing away with the icon all-together (probably should have mentioned this in the proposal, thank you for calling it out!) However, I thought that keeping an icon present would still retain the importance of prefix reservation for security reasons and keep things consistent with what users are used to. I do think that this is a good option to consider though! Would love to get some more opinions

Copy link
Member

@nkolev92 nkolev92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great write-up!
I like the icon in this proposal, but I like the icon in what @JonDouglas proposed as well.
342529785-1072f446-c42b-40d5-8d8e-6c042fc41350

I don't have an opinion about the text beyond real estate considerations.

I have a slight preference towards the icon I linked.

Copy link
Contributor

@JonDouglas JonDouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lgtm. May want to do a quick team review to finalize the settled concept & merge.

@aortiz-msft
Copy link
Contributor

@albarry4 - How can we validate the icons with customers ahead of making the change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants