Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NU5100 wording is confusing/inaccurate #14081

Open
Youssef1313 opened this issue Feb 3, 2025 · 2 comments
Open

NU5100 wording is confusing/inaccurate #14081

Youssef1313 opened this issue Feb 3, 2025 · 2 comments
Assignees
@zivkan
Labels
Area:ErrorHandling warnings and errors/log messages & related error codes. Category:Quality Week Issues that should be considered for quality week Priority:2 Issues for the current backlog. Type:DCR Design Change Request

Comments

@Youssef1313
Copy link

https://github.com/NuGet/NuGet.Client/blob/fa6bd3682bb698604a09d63601a708f2b357b7a8/src/NuGet.Core/NuGet.Packaging/Rules/AnalysisResources.resx#L123-L125

The message is very much geared towards having assemblies in lib, but other directories can have assemblies as well.

The list of directories allowed by the rule is:

https://github.com/NuGet/NuGet.Client/blob/fa6bd3682bb698604a09d63601a708f2b357b7a8/src/NuGet.Core/NuGet.Packaging/Rules/MisplaceAssemblyOutsideLibRule.cs#L55-L62

(The fact that build is allowed while buildTransitive is not is questionable. I opened a separate issue for that #14080)
@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link

Issue is missing Type label, remember to add a Type label

@microsoft-github-policy-service microsoft-github-policy-service bot added the missing-required-type The required type label is missing. label Feb 4, 2025
@jeffkl jeffkl added Type:DCR Design Change Request Area:ErrorHandling warnings and errors/log messages & related error codes. Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. and removed missing-required-type The required type label is missing. labels Feb 10, 2025
@jeffkl
Copy link
Contributor

jeffkl commented Feb 10, 2025

Team Triage: @OliaG can you please suggest the wording improvement here and someone can get it updated?

@jeffkl jeffkl added Priority:2 Issues for the current backlog. Category:Quality Week Issues that should be considered for quality week and removed Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. labels Feb 10, 2025
@zivkan zivkan self-assigned this Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zivkan zivkan

Labels
Area:ErrorHandling warnings and errors/log messages & related error codes. Category:Quality Week Issues that should be considered for quality week Priority:2 Issues for the current backlog. Type:DCR Design Change Request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zivkan @jeffkl @Youssef1313