Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NU5100 (AssemblyOutsideLibWarning): Why build is allowed but buildTransitive is not? #14080

Open
Youssef1313 opened this issue Feb 3, 2025 · 2 comments · May be fixed by NuGet/NuGet.Client#6283
Open

NU5100 (AssemblyOutsideLibWarning): Why build is allowed but buildTransitive is not? #14080

Youssef1313 opened this issue Feb 3, 2025 · 2 comments · May be fixed by NuGet/NuGet.Client#6283
Assignees
@zivkan
Labels
Functionality:Pack Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Type:DCR Design Change Request

Comments

@Youssef1313
Copy link

The rule MisplaceAssemblyOutsideLibRule allows assemblies in build directory, but doesn't allow them in buildTransitive. Shouldn't the warning be present for both build and buildTransitive? AFAIK, there is no special treatment for dlls in either build or buildTransitive.

But for both cases, there is a possibility of false positives for cases where the package author is doing something very custom and including the dll as Reference via props or targets.
@Youssef1313 Youssef1313 mentioned this issue Feb 3, 2025
Open
@baronfel
Copy link

baronfel commented Feb 3, 2025

If this is the case, buildMultitargeting should also be considered.

@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link

Issue is missing Type label, remember to add a Type label

@microsoft-github-policy-service microsoft-github-policy-service bot added the missing-required-type The required type label is missing. label Feb 4, 2025
@jeffkl jeffkl added Type:DCR Design Change Request Functionality:Pack Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. and removed missing-required-type The required type label is missing. labels Feb 10, 2025
@zivkan zivkan self-assigned this Feb 18, 2025
@zivkan zivkan linked a pull request Feb 22, 2025 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zivkan zivkan

Labels
Functionality:Pack Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Type:DCR Design Change Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dont raise NU5100 when dll in buildTransitive NuGet/NuGet.Client
4 participants
@baronfel @zivkan @jeffkl @Youssef1313