Skip to content

Revert "[train][step-wise] Add prefix-aware merging for step-wise training"#1537

Merged
CharlieFRuan merged 1 commit intomainfrom
revert-1532-charlie/merge-stepwise-output
Apr 20, 2026
Merged

Revert "[train][step-wise] Add prefix-aware merging for step-wise training"#1537
CharlieFRuan merged 1 commit intomainfrom
revert-1532-charlie/merge-stepwise-output

Conversation

@CharlieFRuan
Copy link
Copy Markdown
Member

@CharlieFRuan CharlieFRuan commented Apr 20, 2026

Reverts #1532


Open in Devin Review

@CharlieFRuan CharlieFRuan merged commit 77ee63f into main Apr 20, 2026
3 of 5 checks passed
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the prefix-aware merging feature for step-wise training, including the "merge_stepwise_output" configuration and its implementation. The "postprocess_generator_output" method signature has been updated to return only "GeneratorOutput", with corresponding updates to trainers, examples, tests, and documentation. I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant