Skip to content

Fix loss_fn_outputs right-aligned slicing in Tinker API path #1367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CharlieFRuan merged 3 commits into from
Mar 23, 2026
Merged

Fix loss_fn_outputs right-aligned slicing in Tinker API path #1367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b6c98af
Fix loss_fn_outputs using left-aligned slicing on right-aligned tensors
CharlieFRuan Mar 23, 2026
4affd1c
fix
CharlieFRuan Mar 23, 2026
62434c2
update
CharlieFRuan Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions skyrl/backends/skyrl_train/workers/megatron/megatron_model_wrapper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,8 +297,12 @@ def loss_func(logits, data):

loss_fn_outputs.append(
{
"logprobs": action_log_probs[i, :valid_len].detach().cpu().tolist(),
"elementwise_loss": elementwise_loss[i, :valid_len].detach().cpu().tolist(),
"logprobs": (
action_log_probs[i, -valid_len:].detach().cpu().tolist() if valid_len > 0 else []
),
"elementwise_loss": (
elementwise_loss[i, -valid_len:].detach().cpu().tolist() if valid_len > 0 else []
),
}
)

Expand Down Expand Up @@ -351,7 +355,7 @@ def loss_func(logits, data):
for i, valid_len in enumerate(valid_lens):
loss_fn_outputs.append(
{
"logprobs": detached_log_probs[i, :valid_len].tolist(),
"logprobs": detached_log_probs[i, -valid_len:].tolist() if valid_len > 0 else [],
}
)

Expand Down
8 changes: 5 additions & 3 deletions skyrl/backends/skyrl_train/workers/worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -856,8 +856,10 @@ def _forward_backward_micro(

loss_fn_outputs.append(
{
"logprobs": action_log_probs[i, :valid_len].detach().cpu().tolist(),
"elementwise_loss": elementwise_loss[i, :valid_len].detach().cpu().tolist(),
"logprobs": action_log_probs[i, -valid_len:].detach().cpu().tolist() if valid_len > 0 else [],
"elementwise_loss": (
elementwise_loss[i, -valid_len:].detach().cpu().tolist() if valid_len > 0 else []
),
}
)

Expand Down Expand Up @@ -913,7 +915,7 @@ def _forward_backward_micro(
for i, valid_len in enumerate(valid_lens):
loss_fn_outputs.append(
{
"logprobs": detached_log_probs[i, :valid_len].tolist(),
"logprobs": detached_log_probs[i, -valid_len:].tolist() if valid_len > 0 else [],
}
)

Expand Down
Loading