[StepWise] Trivial fix to avg_response_length metric#1351
Merged
CharlieFRuan merged 2 commits intomainfrom Mar 19, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
The pull request correctly addresses the issue of avg_response_length calculation in step-wise training. By removing the conditional logic based on is_last_step, the metric now accurately reflects the average length of all response IDs, which are per-turn samples. The documentation has also been updated to reflect this change, improving clarity and consistency.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
devpatelio
pushed a commit
that referenced
this pull request
Mar 20, 2026
Fixes comment #1281 (comment) There was no good reason to only account for `is_last_step` since response IDs are not cumulative in step-wise training (unlike input tokens, which are cumulative)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes comment #1281 (comment)
There was no good reason to only account for
is_last_stepsince response IDs are not cumulative in step-wise training (unlike input tokens, which are cumulative)