-
Notifications
You must be signed in to change notification settings - Fork 316
[CI] Make MultiItemDataset a global variable after switch to spawn
#1346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -840,22 +840,23 @@ def test_validate_generator_output_element_length_mismatch(): | |
| validate_generator_output(len(input_batch["prompts"]), generator_output) | ||
|
|
||
|
|
||
| def test_build_dataloader_seeding(dummy_config): | ||
| """Test that build_dataloader correctly seeds the dataloader for reproducible shuffling.""" | ||
| # Create a dataset with multiple distinct items to test shuffling | ||
| class MultiItemDataset: | ||
| def __init__(self, size=10): | ||
| self.data = [f"item_{i}" for i in range(size)] | ||
|
|
||
| def __len__(self): | ||
| return len(self.data) | ||
|
|
||
| # Create a dataset with multiple distinct items to test shuffling | ||
| class MultiItemDataset: | ||
| def __init__(self, size=10): | ||
| self.data = [f"item_{i}" for i in range(size)] | ||
| def __getitem__(self, idx): | ||
| return self.data[idx] | ||
|
|
||
| def __len__(self): | ||
| return len(self.data) | ||
| def collate_fn(self, batch): | ||
| return batch | ||
|
|
||
| def __getitem__(self, idx): | ||
| return self.data[idx] | ||
|
|
||
| def collate_fn(self, batch): | ||
| return batch | ||
| def test_build_dataloader_seeding(dummy_config): | ||
| """Test that build_dataloader correctly seeds the dataloader for reproducible shuffling.""" | ||
|
|
||
| dataset = MultiItemDataset(size=20) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To improve clarity and indicate that this class is intended for internal use within this test module, consider renaming it to
_MultiItemDataset. This follows the Python convention (PEP 8) for internal-use names and prevents it from being accidentally used elsewhere.References