fix(desktop): separate auto-speak from gateway voice.auto_tts to prevent double-speech - #99212
Open
salch-cred wants to merge 2 commits into
Open
salch-cred wants to merge 2 commits into
salch-cred wants to merge 2 commits into
Conversation
Covers the Android psutil installer helpers: - PsutilAndroidInstallError is a RuntimeError subclass - MARKER/REPLACEMENT contain expected substrings - _normalize_member_parts strips the tarball prefix - PSUTIL_URL points to a .tar.gz for psutil
…ktop auto-speak toggle The Desktop 'Read Replies Aloud' toggle synced to voice.auto_tts in config.yaml — the gateway's auto-TTS config key. This enabled BOTH the Desktop renderer's local audio path AND the gateway's TTS pipeline, causing double-speech on every response (NousResearch#99076). voice.auto_tts controls whether the messaging-gateway fires TTS on every assistant turn (independent of any Desktop session). The Desktop's per- session auto-speak is a renderer-local feature that should not touch the gateway pipeline at all. Fix: - constants.ts: change the voice settings key from 'voice.auto_tts' to 'desktop.voice.auto_speak'. - config_defaults.py: add desktop.voice.auto_speak: false as a new Desktop-only key under the desktop.* namespace so it never conflicts with gateway-level voice.* settings. Fixes NousResearch#99076
alt-glitch
added
type/bug
Contributor
This was referenced Sep 7, 2026
Contributor
|
Exact-head KEEP on #99212 head f7f0684. KEEP separating Desktop auto-speak from gateway CHECK: gateway-only auto-TTS unchanged when desktop speak is off. CHECK: no session-state race with continuous voice (#95180 stack). Author salch-cred not kvnloo. No competing PR. |
23 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Desktop auto-speak toggle synced to voice.auto_tts causing gateway TTS also to fire. Use desktop.voice.auto_speak (Desktop-only key). Fixes #99076.