fix(simplex): send() returns failure when WebSocket absent instead of silent success - #99091
Closed
salch-cred wants to merge 2 commits into
Closed
salch-cred wants to merge 2 commits into
salch-cred wants to merge 2 commits into
Conversation
Covers the Android psutil installer helpers: - PsutilAndroidInstallError is a RuntimeError subclass - MARKER/REPLACEMENT contain expected substrings - _normalize_member_parts strips the tarball prefix - PSUTIL_URL points to a .tar.gz for psutil
…t absent send() routed text through _send_ws(), which silently drops the write when self._ws is None and returns None. send() then returned SendResult(success=True) regardless, giving callers a false positive — the message was never delivered (NousResearch#98949, repro 1). Add a guard at the top of the content-send path: if _ws is absent, log a warning and return SendResult(success=False) immediately so the gateway can surface the delivery failure rather than silently swallowing it. Media-only paths (already guarded by send_document/send_voice returning their own SendResult) are unaffected. Fixes NousResearch#98949
alt-glitch
added
type/bug
Contributor
Duplicate of #27628. That open PR already makes unavailable and failed SimpleX WebSocket sends return a failed SendResult; this branch implements the absent-socket subset. |
Contributor
Author
|
Closing — duplicate of #27628 which covers the full unavailable/failed send surface. |
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
send() returned success=True when _ws was absent because _send_ws() silently drops. Add guard: check _ws before sending, return failure if absent. Fixes #98949.