Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #97427.
When replaying encrypted reasoning with
store: false, the server-side reasoning ID is intentionally omitted. This change also omits the paired assistant-message ID, preventing the API from rejecting an incomplete replay graph.It preserves short message IDs for turns without replayed encrypted reasoning and for messages after a reasoning-to-tool round, retaining cache reuse where the graph is independent.
Tests cover:
Validation:
uv run --extra dev pytest tests/agent/test_codex_responses_adapter.py -quv run --extra dev ruff check agent/codex_responses_adapter.py tests/agent/test_codex_responses_adapter.py