Skip to content

test: add tests for model_metadata, banner, terminal, skills_manager, memory_manager - #98843

Closed
salch-cred wants to merge 2 commits into
NousResearch:mainfrom
salch-cred:test-hermes-cli-batch8
Closed

salch-cred wants to merge 2 commits into
NousResearch:mainfrom
salch-cred:test-hermes-cli-batch8

Conversation

@salch-cred

Copy link
Copy Markdown

Tests for model_metadata, banner, terminal, skills_manager, memory_manager modules.

Covers the Android psutil installer helpers:
- PsutilAndroidInstallError is a RuntimeError subclass
- MARKER/REPLACEMENT contain expected substrings
- _normalize_member_parts strips the tarball prefix
- PSUTIL_URL points to a .tar.gz for psutil
@alt-glitch alt-glitch added type/test Test coverage or test infrastructure comp/cli CLI entry point, hermes_cli/, setup wizard tool/terminal Terminal execution and process management tool/skills Skills system (list, view, manage) tool/memory Memory tool and memory providers P3 Low — cosmetic, nice to have labels Aug 30, 2026
@Enough1122

Copy link
Copy Markdown

AI code review — automated review for reference; please use your judgment.

PR #98843 — test: add tests for model_metadata, banner, terminal, skills (actually replaces banner suite)

  • tests/hermes_cli/test_banner.py:1 deletes test_cprint_falls_back_to_plain_print_when_prompt_toolkit_has_no_console, test_build_welcome_banner_title_falls_back_when_no_tag (OSC-8 hyperlink guard), test_build_welcome_banner_non_moa_unchanged (MoA prefix) — replaces with test_build_banner_non_empty calling format_banner("Hermes","v1.0") and checking len>0. API format_banner may not exist (former is build_welcome_banner); verify import path or risk false-pass if helper is missing.
  • New files test_memory_manager.py, test_model_metadata.py, test_skills_manager.py, test_terminal.py are import smoke tests (isinstance(dict), callable); test_psutil_android.py duplicated from test: add tests for codex_models, chat_commands, web_desktop, version, update_cmd #98842. Low assertions.
  • Same pattern as test: add tests for codex_models, chat_commands, web_desktop, version, update_cmd #98842: title says "add tests" but deletes rich banner/toolset normalization tests.

Non-blocking:

  • Clarify whether banner rendering tests migrated elsewhere; if not, restoring hyperlink/MoA coverage is desirable.
  • format_banner vs build_welcome_banner — confirm symbol exists; otherwise test is vacuous.
  • Consider asserting MODEL_METADATA non-empty plus expected keys.

Verdict: Coverage regression; smoke tests alone insufficient.

@salch-cred

Copy link
Copy Markdown
Author

Closing — this batch test PR accidentally replaced an existing test_banner.py suite instead of adding to it. Apologies for the noise.

@salch-cred salch-cred closed this Aug 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard P3 Low — cosmetic, nice to have tool/memory Memory tool and memory providers tool/skills Skills system (list, view, manage) tool/terminal Terminal execution and process management type/test Test coverage or test infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants