Skip to content

fix(memory): align Hindsight client pin at 0.9.2 - #98527

Closed
ttomiczek wants to merge 1 commit into
NousResearch:mainfrom
ttomiczek:fix/hindsight-client-0-9-2-sync
Closed

ttomiczek wants to merge 1 commit into
NousResearch:mainfrom
ttomiczek:fix/hindsight-client-0-9-2-sync

Conversation

@ttomiczek

Copy link
Copy Markdown

Summary

Updates Hermes's Hindsight client from the stale 0.6.1 pin to the reviewed 0.9.2 release across every enforcement path:

  • the hindsight optional dependency and committed uv.lock
  • the Hindsight provider minimum and plugin manifest
  • memory.hindsight in tools/lazy_deps.py
  • the relative exclude-newer exemption required to resolve this exact reviewed release immediately

Adds a regression test covering the pin, lock resolution, and exclude-newer exemption.

This prevents normal updates and lazy dependency healing from restoring the obsolete 0.6.1 client after an operator has moved to the 0.9.x Hindsight stack.

Verification

92 passed in 5.53s
uv lock --check

Refs #86992

@ttomiczek
ttomiczek requested a review from a team August 30, 2026 11:24
@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/plugins Plugin system and bundled plugins comp/tools Tool registry, model_tools, toolsets tool/memory Memory tool and memory providers dependencies Pull requests that update a dependency file area/memory Memory subsystem: store, providers, sync, background reviews sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades labels Aug 30, 2026
@Enough1122

Copy link
Copy Markdown

AI code review — automated review for reference; please use your judgment.

PR #98527 — fix(memory): align Hindsight client pin at 0.9.2

Summary: Bumps hindsight-client from 0.6.1 to 0.9.2 across pyproject.toml extra, uv.lock, plugins/memory/hindsight/plugin.yaml (>=0.6.1 to ==0.9.2), tools/lazy_deps.py, and _MIN_CLIENT_VERSION. Adds hindsight-client = false to exclude-newer-package so relative 14-day cutoff doesn't hide the reviewed release.

Non-blocking observations:

Verdict: Clean coordinated pin bump. No blocking issues.

teknium1 added a commit that referenced this pull request Sep 22, 2026
…mes list-typed files and reads hooks:

- hindsight-client==0.6.1 / mem0ai==2.0.10 exact pins made _is_satisfied() reject every newer
  compatible release, so hermes update kept downgrading a working client and broke embedded
  daemons whose DB a newer client had migrated (#86992, #39424, #98407, #99317). The lazy entries
  now mirror the plugin manifests (>=0.6.1,<1 and >=2.0.10,<3); pyproject extras stay the floor
  install. Slim redo of #99557 (nateEc) / #98416 / #98527 (ttomiczek) / #39754.
- A list-typed plugin.yaml is refused with "top level must be a mapping" instead of an
  AttributeError swallowed as "Failed to parse" (#14066, discovery side).
- ``hooks:`` (the spelling bundled manifests carried) still populates provides_hooks (#108371).
teknium1 added a commit that referenced this pull request Sep 22, 2026
…mes list-typed files and reads hooks:

- hindsight-client==0.6.1 / mem0ai==2.0.10 exact pins made _is_satisfied() reject every newer
  compatible release, so hermes update kept downgrading a working client and broke embedded
  daemons whose DB a newer client had migrated (#86992, #39424, #98407, #99317). The lazy entries
  now mirror the plugin manifests (>=0.6.1,<1 and >=2.0.10,<3); pyproject extras stay the floor
  install. Slim redo of #99557 (nateEc) / #98416 / #98527 (ttomiczek) / #39754.
- A list-typed plugin.yaml is refused with "top level must be a mapping" instead of an
  AttributeError swallowed as "Failed to parse" (#14066, discovery side).
- ``hooks:`` (the spelling bundled manifests carried) still populates provides_hooks (#108371).
@teknium1

Copy link
Copy Markdown
Collaborator

Thanks @ttomiczek — instead of bumping the exact pin (already stale vs PyPI), the lazy entry now mirrors the manifest range hindsight-client>=0.6.1,<1.

Superseded by #118841 (merge 74f726c), which credits this PR. Closing.

@teknium1 teknium1 closed this Sep 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/memory Memory subsystem: store, providers, sync, background reviews comp/plugins Plugin system and bundled plugins comp/tools Tool registry, model_tools, toolsets dependencies Pull requests that update a dependency file P3 Low — cosmetic, nice to have sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades tool/memory Memory tool and memory providers type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants