You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Duplicate of #44044 for the configured mcp-<server> pre-discovery validation repair; #44044 is the broader open implementation across startup validators. This PR also carries separate stdio watcher-warning cleanup, which should be preserved if work is consolidated.
Thanks for flagging this. I removed the duplicate MCP-prefixed validation changes. This PR now contains only the independent stdio watcher coroutine cleanup; #44044 remains the implementation for pre-discovery validation.
Closing with credit — the leak this fixes landed on main via #100920 (fe3e5dc), carrying @loulanyue's earlier #96044 fix (Aug 27) with a different shape: the probe now uses inspect.iscoroutinefunction(_watch_children) instead of creating the coroutine once and reusing it. Same bug, same outcome (0 leaked coroutines, verified live). Thanks @Serph91P for the independent fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
area/configConfig system, migrations, profilescomp/cliCLI entry point, hermes_cli/, setup wizardduplicateThis issue or pull request already existsP2Medium — degraded but workaround existstool/mcpMCP client and OAuthtype/bugSomething isn't working
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RuntimeWarning: coroutine ... was never awaitedThe MCP-prefixed pre-discovery validation changes were removed because they are already covered more broadly by #44044.
Verification
uv run pytest -q tests/tools/test_mcp_stdio_fastfail_reconnect.py(2 passed)uv run pytest -q tests/tools/test_mcp*.py(596 passed)uv run ruff check tools/mcp_tool.py tests/tools/test_mcp_stdio_fastfail_reconnect.pygit diff --check