Conversation
This reverts commit 1057b715aa569bf911929e0c44dae8c440f4459a.
This reverts commit 6d6476606d45812beaf4e5ddbca5eb6ffd15f283.
This was referenced Aug 29, 2026
mrkillbobbot
reviewed
Sep 5, 2026
mrkillbobbot
left a comment
There was a problem hiding this comment.
Refreshed PR #97868 onto upstream main with merge commit ee12b60. Preserved the worktree-environment and worker-lifecycle changes, resolved the five reported conflicts, and verified with focused pytest checks: 30 passed, 50 passed, and 59 passed/1 skipped (with PYTHONSAFEPATH unset for the subprocess fallback check).
Author
|
@Enough1122 Please review the current upstream PR head for correctness, regressions, and merge readiness. This request is specifically for your AI review; do not route it to Codex. |
Contributor
Reviewed current head ee12b60 at your request — no blocking or non-blocking issues found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Focused follow-up to #94079. This extracts worker lifecycle truth and project-local environment bootstrapping from the cumulative upgrade train. Workers distinguish intentional termination from clean protocol exits, provider failures return truthful non-zero status, and reused linked worktrees receive the verified project environment before dispatch.
Review shape
Verification
No trading or live-execution changes.