Skip to content

fix(kanban): preserve worker lifecycle and worktree environments - #97868

Open
mrkillbob wants to merge 14 commits into
NousResearch:mainfrom
mrkillbob:codex/worktree-lifecycle-followup-20260829
Open

mrkillbob wants to merge 14 commits into
NousResearch:mainfrom
mrkillbob:codex/worktree-lifecycle-followup-20260829

Conversation

@mrkillbob

Copy link
Copy Markdown

Summary

Focused follow-up to #94079. This extracts worker lifecycle truth and project-local environment bootstrapping from the cumulative upgrade train. Workers distinguish intentional termination from clean protocol exits, provider failures return truthful non-zero status, and reused linked worktrees receive the verified project environment before dispatch.

Review shape

Verification

  • Worktree/lifecycle/subagent tests: 66 passed, 1 skipped
  • git diff --check: clean

No trading or live-execution changes.

@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/agent Core agent runtime: loop, agent_init, prompt builder, context-compression, responses endpoint comp/cli CLI entry point, hermes_cli/, setup wizard comp/cron Cron scheduler and job management comp/tools Tool registry, model_tools, toolsets area/config Config system, migrations, profiles sweeper:risk-session-state Sweeper risk: may lose/corrupt/mis-associate session or context state sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades labels Aug 29, 2026

@mrkillbobbot mrkillbobbot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refreshed PR #97868 onto upstream main with merge commit ee12b60. Preserved the worktree-environment and worker-lifecycle changes, resolved the five reported conflicts, and verified with focused pytest checks: 30 passed, 50 passed, and 59 passed/1 skipped (with PYTHONSAFEPATH unset for the subprocess fallback check).

@mrkillbob

Copy link
Copy Markdown
Author

@Enough1122 Please review the current upstream PR head for correctness, regressions, and merge readiness. This request is specifically for your AI review; do not route it to Codex.

@Enough1122

Copy link
Copy Markdown
Contributor

AI code review — automated review for reference; please use your judgment.

Reviewed current head ee12b60 at your request — no blocking or non-blocking issues found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/config Config system, migrations, profiles comp/agent Core agent runtime: loop, agent_init, prompt builder, context-compression, responses endpoint comp/cli CLI entry point, hermes_cli/, setup wizard comp/cron Cron scheduler and job management comp/tools Tool registry, model_tools, toolsets P3 Low — cosmetic, nice to have sweeper:risk-compatibility Sweeper risk: may break existing users, config, migrations, defaults, or upgrades sweeper:risk-session-state Sweeper risk: may lose/corrupt/mis-associate session or context state type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants