Repository navigation
Conversation
The ui_meta projection sliced messages at 1200 chars with no signal that the body continued. Stamp truncated and keep the marker inside the existing per-message budget.
1 task done
Collaborator
|
Thanks @686f6c61 — the work in this PR has landed on
Your contribution is credited there (cherry-picked authorship / co-author trailer or credit in the PR body; see the linked PR for what was kept and what was trimmed). Closing this one as landed / superseded so the backlog reflects reality. If something in your original diff is still missing on current |
13 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The Desktop group-chat
ui_metaprojection sliced each message at 1200 characters with no marker, so a receiving client/bot saw a mid-sentence cut and had no way to know the body continued.Sync text that exceeds the budget now ends with
… [truncated](kept inside the same 1200-char cap) and setstruncated: trueon the projected message. The 48KB envelope bound is unchanged.This does not raise the per-message cap or switch to incremental full-text delivery — that would be a larger sync-protocol change. Receivers at least know the payload was cut.
Related Issue
Fixes #97373
Type of Change
Changes Made
apps/desktop/src/plugins/hermes-bots/group-chat.ts:compactGroupChatSyncText+ stamptruncatedapps/desktop/src/plugins/hermes-bots/types.ts: optionaltruncatedonGroupMessageapps/desktop/src/plugins/hermes-bots/group-chat.test.ts: marker + flag on oversized sync linesHow to Test
Not runtime-tested in a live multi-bot room.
Checklist
Code
fix(scope):,feat(scope):, etc.)Documentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
N/A