fix(doctor): prevent false positives for WAL and launcher checks - #97456
Closed
wooyongbin3-cpu wants to merge 1 commit into
Closed
wooyongbin3-cpu wants to merge 1 commit into
wooyongbin3-cpu wants to merge 1 commit into
Conversation
Two false positives in hermes doctor:
1. WAL check: Large WAL file was flagged as an issue even when fully
checkpointed. Now checks PRAGMA wal_checkpoint(PASSIVE) result before
flagging. Fully checkpointed WALs are reported as healthy.
2. Launcher check: ~/.local/bin/hermes not found was reported even when
hermes is available on PATH from another location (e.g., /usr/local/bin).
Now checks shutil.which("hermes") before reporting missing.
These are both cosmetic fixes that prevent unnecessary repair suggestions.
Fixes NousResearch#96976
🤖 Generated with Codebuff
Co-Authored-By: Codebuff <noreply@codebuff.com>
alt-glitch
added
type/bug
Contributor
Duplicate of #97133: it implements the same WAL checkpoint-state and PATH-resolved launcher checks. |
Collaborator
|
Closing as a duplicate of #97133, which carries tests and the fuller WAL-health classification; #97133 stays open for a doctor-lane review. Thanks @wooyongbin3-cpu. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #96976 by preventing false positives in hermes doctor for WAL and launcher checks.
Problem
Two false positives in hermes doctor:
~/.local/bin/hermes not foundwas reported even when hermes is available on PATH from another locationSolution
1. WAL Check
Now checks
PRAGMA wal_checkpoint(PASSIVE)result before flagging:log == checkpointed), reports as healthy2. Launcher Check
Now checks
shutil.which("hermes")before reporting missing:Changes
hermes_cli/doctor.py: Added checkpoint verification and PATH check🤖 Generated with Codebuff
Co-Authored-By: Codebuff noreply@codebuff.com