Conversation
… + token budget guard - Add group-chat-config.ts: config.yaml-driven group_chat settings + free-model detection - Make GROUP_CHAT_MAX_ROUNDS config-aware: free models get unlimited rounds (up to HARD_CAP=20), paid models default 3 - Add token-budget guard: cumulative room-log tokens exceeding group_chat.token_budget (default 80k chars) force exitKind='capped' independent of round count - Detect free models via :free suffix or free_models[] allowlist - Add config.yaml schema in cli-config.yaml.example under group_chat: Refs: NousResearch#96726 (maintainer flagged this as the follow-up needed for the new Bot Mode modules)
- Remove unused GROUP_CHAT_MAX_ROUNDS import (unused-imports/no-unused-imports) - Reorder named imports: getCurrentModelName before getGroupChatConfig (perfectionist/sort-named-imports) Fixes PR NousResearch#97326 CI job 98930161351 JS & TS checks failure.
Contributor
Overall: Feature that makes What it does
Non-blocking notes
Non-blocking — please use your judgment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
group-chat-config.ts: config.yaml-drivengroup_chat.*settings + free-model detectionGROUP_CHAT_MAX_ROUNDSconfig-aware: free models (:freesuffix orfree_models[]allowlist) get unlimited rounds up toHARD_CAP=20, paid models default tomax_rounds: 3group_chat.token_budget(default 80k chars) forceexitKind='capped'independent of round count — the real safety net for pathological cascadesgetGroupChatConfig(),isFreeModel(),getEffectiveRoundCap(),getCurrentModelName()helperscli-config.yaml.exampleundergroup_chat:Why
Hardcoded 3-round cap is too tight for free-model rooms (where API cost is zero) and too loose for paid-model rooms (where each round burns real money). A single config block drives everything automatically.
Config
Safety
HARD_CAP=20prevents unbounded free-model cascades (20 rounds × 6 bots = 120 messages max)max_rounds(default 3)exitKind='capped'logged to activity feed for every termination pathTest plan
free_models+:freesuffix → allowlist is sole gate (no bypass)Refs: #96726, #96842 (closed — superseeded by this port to new module structure)