Conversation
Contributor
Overall: Keys remote kernels by tool set to avoid stale stubs. What it does
Non-blocking notes
Correct isolation fix, same invariant as local (#94647). Non-blocking — please use your judgment. |
kshitijk4poor
added a commit
that referenced
this pull request
Sep 5, 2026
kshitijk4poor
pushed a commit
that referenced
this pull request
Sep 5, 2026
…et (#97263) The hermes_tools stub module a remote kernel imports is generated from sandbox_tools once, at spawn, but the registry key was (owner, env_type, task_env_id) only: a later execute_code call with a different tool set (skill loaded, toolset toggled) reused the kernel and got stale stubs. The tool set is now part of the key; a different set gets its own kernel and the over-cap eviction keeps the newest. Salvaged from #97265 by @Liuzikaii.
Contributor
|
Landed on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hermes_tools.pywhen capabilities changeFixes #97263
Testing
python -m pytest -p no:cacheprovider tests/tools/test_code_kernel_remote.py tests/tools/test_code_kernel.py -qpython -m ruff check tools/code_kernel_remote.py tests/tools/test_code_kernel_remote.py