feat(commands): establish desktop client command bindings - #97124
andrexibiza wants to merge 1 commit into
Conversation
Overall: Introduces desktop client command binding projection for catalog v2/mixed-version peers. What it does
Non-blocking notes
Well-structured, tested, no issues. Non-blocking — please use your judgment. |
Signed-off-by: Axl Ibiza, MBA <andrexibiza@gmail.com>
601ac5f to
9a23b49
Compare
|
Closure repair complete on exact I fixed the JS/TS failure in the submitted Desktop binding ( Exact hosted receipts on the one surviving commit:
GitHub reports the PR open, non-draft, and mergeable. The PR body has been refreshed to the exact base/head/tree and green execution receipts. No review was submitted on my own code. |
PR 5 — Desktop client binding seam
This is the independently landable Desktop slice under #96692. It introduces the execution-only projection that lets Desktop contribute genuinely client-owned actions, pickers, and dedicated RPC bindings without becoming another semantic command registry.
Exact object
4209d371aa1bb8840ce8447555bdd863a1a96c389a23b4951d6bfae7a57d59a99e1643dcf16e72939db5fe6e45d1628522e9d2d1ee9bef71d6df4eefSigned-off-by: Axl Ibiza, MBA <andrexibiza@gmail.com>33269223135— SUCCESS33269222838— SUCCESS33269222850— SUCCESSChanged paths
apps/desktop/src/lib/desktop-command-bindings.tsapps/desktop/src/lib/desktop-command-bindings.test.tsContract
action,picker, and dedicatedrpcsurfaces.command_idfromcommands.catalog.v2.commandId,canonicalName, andsurface. Catalog description, aliases, argument semantics, visibility, availability, and policy remain server-owned.Repair / release-object reconciliation
The original submitted head
601ac5f54238b4d42e5be153872114393ba5270bwas red in the JS/TS workspace checks. The defect was the named-import order in the new Desktop binding module under the repository'sperfectionist/sort-named-importsrule. Rather than stack a green fix on a surviving red commit, this PR was rematerialized as the single current-main commit above with the import ordering corrected and product behavior unchanged. Exact-head JS/TS checks are now green inside CI33269223135.Collision / provenance scan
#96791 remains the merged current-main owner of registry-backed Desktop catalog metadata and dynamic command projection. This PR composes with that work and does not edit
desktop-slash-commands.ts, the composer dispatcher, the Python registry, or the gateway dispatcher. The two submitted paths are disjoint from sibling command slices #97129 and #97143.Focused characterization
The test suite covers the complete current Desktop-local surface (14 actions, 2 pickers, 2 RPCs), stable-id and v1 fallback behavior, alias canonicalization, server/unavailable refusal, RPC parameter preservation, immutable settlement, blank-id rejection, duplicate-id rejection, and duplicate-canonical rejection.
Refs #96692