Conversation
helix4u
marked this pull request as ready for review
August 28, 2026 00:22
This was referenced Aug 28, 2026
Collaborator
Author
Collaborator
|
Thanks — landed on main via #101265 (your commit cherry-picked, authorship preserved; tests trimmed). Measured: dispatch 77ms → 2ms, real |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What does this PR do?
Desktop starts a new
hermes serveprocess for its backend, but that exact built-in command currently constructs the complete Hermes argparse tree before it can dispatch. On Windows, the unrelated command and plugin parser setup adds filesystem and translation work to every cold Desktop launch.This adds a narrow
servefast path built from the same parser configuration function as the normal command tree. Unrecognized arguments, global options, help, container routing, and an explicit opt-out all fall back to the existing parser, so the optimization does not create a second command contract.Desktop performance series
This change is one independently reviewable layer of the same Desktop startup and first-interaction performance pass.
hermes serveentry path.The three Python backend PRs share startup files but solve separate stages. Recommended landing order is #96749, then #96750, then #96751, rebasing the next PR only after the preceding one lands. #97032 is an independently reviewable Electron ordering change. The remaining renderer and Bot Mode PRs can also land independently; their effects compose without making cached state authoritative.
This PR owns the earliest Python entry layer: an unambiguous Desktop
servelaunch avoids building the unrelated CLI parser tree.Related Issue
N/A
Type of Change
Changes Made
serveparser configuration inhermes_cli/subcommands/dashboard.pyso both launch paths share every option and default.servebefore constructing the full parser tree inhermes_cli/main.py.HERMES_DISABLE_FAST_SERVE_LAUNCH=1.How to Test
scripts/run_tests.sh tests/hermes_cli/test_fast_serve_launch.py -q -j 4.hermes serve --port 0 --no-openand confirm it reaches the normal backend command implementation; launchhermes serve --helpand confirm it uses the complete parser help path.Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
Focused result: 5 tests passed.