Skip to content

fix(desktop): Bots home no longer flashes over the chat during bot switches (salvage #95917) - #96648

Merged
teknium1 merged 1 commit into
mainfrom
salv/95917-bots-home-flash
Aug 28, 2026
Merged

teknium1 merged 1 commit into
mainfrom
salv/95917-bots-home-flash

Conversation

@teknium1

Copy link
Copy Markdown
Collaborator

Summary

Switching bots no longer flashes the Bots home workspace in front of the current chat while the destination bot's canonical chat is still opening. Root cause: passive workspace reconciliation could open Bots home in the pre-open handoff window a bot switch left unguarded (the remaining gap after #92901).

Salvage of #95917 by @helix4u, authorship preserved via cherry-pick.

Changes

  • apps/desktop/src/plugins/hermes-bots/plugin.js: a bot switch owns the handoff from source preparation until the destination chat succeeds, fails, or is canceled; the guard is generation-scoped so a stale async completion cannot clear a newer switch, and choosing a group or leaving Bot Mode cancels it immediately.
  • apps/desktop/src/plugins/hermes-bots/tests/bots-home.test.mjs: 3 new tests (guard blocks reconciliation, generation scoping, cancel on group/mode exit).

Validation

Result
node --test bots-home.test.mjs 50/50 pass
Base current origin/main, clean cherry-pick

Infographic

No more home flash

@github-actions

github-actions Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

૮ >ﻌ< ა ci review

ran on 5367549 — fix(desktop): prevent Bots home flash during chat switch

⚠️ Warnings

OSV vulnerability scan · View job

6 known vulnerabilities found in pinned dependencies.

How to fix:

Review the findings in the Security tab. Update the affected dependencies if a patched version is available.


debug info

CI timings

CI timings · View report · View job

Wall time 2m52s vs 4m4s (-29.5%). 3 job(s) slower, 1 faster, 2 unchanged.

  • JS & TS checks / JS & TS checks: +21.0s
  • OSV scan / Emit review status: +4.0s
  • Check no committed infographics / check-no-committed-infographics: -2.0s
  • All required checks pass: +1.0s

@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/desktop Electron desktop app (apps/desktop/*) labels Aug 27, 2026
@teknium1
teknium1 merged commit 6f8be61 into main Aug 28, 2026
32 checks passed
@teknium1
teknium1 deleted the salv/95917-bots-home-flash branch August 28, 2026 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/desktop Electron desktop app (apps/desktop/*) P3 Low — cosmetic, nice to have type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants