Skip to content

fix(desktop): expanded thinking block swallows wheel scroll (#96094) - #96553

Closed
beplee wants to merge 3 commits into
NousResearch:mainfrom
beplee:fixing-expanded-scroll
Closed

beplee wants to merge 3 commits into
NousResearch:mainfrom
beplee:fixing-expanded-scroll

Conversation

@beplee

@beplee beplee commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Summary

Manually expanded thinking blocks swallow the wheel scroll — the body becomes a dead overflow:auto container whose overscroll-behavior: contain chains the wheel to itself instead of the thread viewport.

Root cause is PR #95783 (be7eefec8d), which added overflow-auto overscroll-contain unconditionally while max-h-40 is gated on isPreview. When expanded (isPreview=false), the body has no height cap → scrollHeight === clientHeight → no internal scroll, yet it still swallows the wheel. Same trap documented for the session list in #84964.

Fix scopes overflow-auto overscroll-contain to the preview only. The expanded body reverts to a normal block — wheel chains to the transcript.

Closes #96094.

Test plan

  • Expanded body no longer carries overflow-auto or overscroll-contain (new test)
  • Preview path unchanged — still carries max-h-40 overflow-auto overscroll-contain
  • Existing streaming.test.tsx tests still pass
  • Branch based on current upstream/main

🤖 Generated with natural-language-commit

…arch#96094)

Move overflow-auto overscroll-contain inside the isPreview conditional
so only the capped preview is a scroll container. The expanded body
(no max-h) reverts to a normal block and chains the wheel to the
thread viewport instead of swallowing it.
@alt-glitch alt-glitch added type/bug Something isn't working comp/desktop Electron desktop app (apps/desktop/*) P3 Low — cosmetic, nice to have duplicate This issue or pull request already exists labels Aug 27, 2026
@alt-glitch

Copy link
Copy Markdown

This was generated by AI during triage.

Duplicate of #96393: this is the same author’s patch for #96094, with the same preview-only overflow/overscroll fix.

@beplee

beplee commented Aug 27, 2026

Copy link
Copy Markdown
Contributor Author

🔄 Rerun CI

@beplee
beplee force-pushed the fixing-expanded-scroll branch from 9d8c681 to 1161ef1 Compare August 27, 2026 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/desktop Electron desktop app (apps/desktop/*) duplicate This issue or pull request already exists P3 Low — cosmetic, nice to have type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Desktop — expanding a thinking block swallows wheel scroll (dead zone after #95783)

2 participants