Conversation
…arch#96094) Move overflow-auto overscroll-contain inside the isPreview conditional so only the capped preview is a scroll container. The expanded body (no max-h) reverts to a normal block and chains the wheel to the thread viewport instead of swallowing it.
4 tasks
Contributor
Author
|
🔄 Rerun CI |
beplee
force-pushed
the
fixing-expanded-scroll
branch
from
August 27, 2026 19:02
9d8c681 to
1161ef1
Compare
Closed
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Manually expanded thinking blocks swallow the wheel scroll — the body becomes a dead
overflow:autocontainer whoseoverscroll-behavior: containchains the wheel to itself instead of the thread viewport.Root cause is PR #95783 (
be7eefec8d), which addedoverflow-auto overscroll-containunconditionally whilemax-h-40is gated onisPreview. When expanded (isPreview=false), the body has no height cap →scrollHeight === clientHeight→ no internal scroll, yet it still swallows the wheel. Same trap documented for the session list in #84964.Fix scopes
overflow-auto overscroll-containto the preview only. The expanded body reverts to a normal block — wheel chains to the transcript.Closes #96094.
Test plan
overflow-autooroverscroll-contain(new test)max-h-40 overflow-auto overscroll-containstreaming.test.tsxtests still passupstream/main🤖 Generated with natural-language-commit