Repository navigation
Conversation
fix(desktop): keep busy tile transcripts stable — correctly scopes tile reconciliation to per-runtime live state.
Approve. |
Collaborator
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Hardens the workspace-tile transcript reconciliation introduced by #95600 / #94255 so a persisted snapshot cannot replace a tile's live output or make unrelated tabs jump.
reconcileTileTranscripts()currently gates every tile with the main pane's global$busystate. That produces both failure directions:The async read also captures tile presence before
getLatestSessionMessages(), allowing a result to land after the tile becomes busy, closes, or is rebound.Changes
$sessionStates(busy,awaitingResponse,needsInput, orturnLive);This is complementary to #95770 (cheap no-change fetch gating) and #96215 (warm-cache refresh on explicit Bot Chat reopen); neither protects an active tile from an in-flight persisted snapshot.
Regression proof
On current
origin/main/v0.20.6, with only a test-harness compatibility default for the oldbusyRefsignature:The five failures are the intended contracts:
On this branch:
Scope
Only these files change:
apps/desktop/src/app/contrib/hooks/use-background-sync.tsapps/desktop/src/app/contrib/hooks/use-background-sync.test.ts