Skip to content

fix(desktop): keep restarted sessions on their owner - #96313

Open
mr-magaia wants to merge 1 commit into
NousResearch:mainfrom
mr-magaia:codex/fix-desktop-session-owner-retention
Open

mr-magaia wants to merge 1 commit into
NousResearch:mainfrom
mr-magaia:codex/fix-desktop-session-owner-retention

Conversation

@mr-magaia

Copy link
Copy Markdown

What

  • Keep selected and tiled stored-session owner scopes foregrounded after restart.
  • Retain a cold-resume owner until the runtime publishes foreground state.
  • Keep explicit local profile selections on This device.
  • Accept backend READY announcements from stderr or buffered output.

Why

After restart, a stored session in All Profiles can have no live runtime scope yet. The idle pruner then closes its owner socket, causing repeated loader flashes. The previous hold only delayed that failure. The current hermes serve process can also emit READY on stderr, and local profile picks could fall through the legacy remote primary route.

Verification

  • 69 targeted desktop tests passed.
  • Desktop type-check passed.
  • Signed macOS build passed codesign --verify --deep --strict.
  • Exact-head UI checks: default, Daniela, Dexter, James, and Mali stayed on This device with zero post-ready anomalies.
  • Exact-head All Profiles persisted-session watch: 25 of 25 clean samples.
  • Longer All Profiles watch before the final upstream rebase: 85 of 85 clean samples.

No new dependencies.

@alt-glitch alt-glitch added type/bug Something isn't working comp/desktop Electron desktop app (apps/desktop/*) area/sessions Session lifecycle, resume, persistence, history area/profiles Multi-profile isolation, HERMES_HOME scoping P2 Medium — degraded but workaround exists sweeper:risk-session-state Sweeper risk: may lose/corrupt/mis-associate session or context state labels Aug 27, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/profiles Multi-profile isolation, HERMES_HOME scoping area/sessions Session lifecycle, resume, persistence, history comp/desktop Electron desktop app (apps/desktop/*) P2 Medium — degraded but workaround exists sweeper:risk-session-state Sweeper risk: may lose/corrupt/mis-associate session or context state type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants