Skip to content

fix(nix): use python312 for package env - #9630

Closed
OwenYWT wants to merge 1 commit into
NousResearch:mainfrom
OwenYWT:fix/nix-python312-sphinx
Closed

fix(nix): use python312 for package env#9630
OwenYWT wants to merge 1 commit into
NousResearch:mainfrom
OwenYWT:fix/nix-python312-sphinx

Conversation

@OwenYWT

@OwenYWT OwenYWT commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

Summary

  • switch the uv2nix package environment from python311 to python312
  • update the dev shell to create Python 3.12 virtual environments
  • add static regression tests for the Nix Python version wiring

Root cause

The current nixpkgs pin includes Sphinx 9.1, which no longer supports Python 3.11. The Nix package builder hardcoded python311, so flake evaluation could fail when pyproject-build-systems wired the Sphinx hook into the Python 3.11 package set.

Test plan

  • python -m pytest -o addopts='' tests/test_nix_metadata.py -q
  • python -m py_compile tests/test_nix_metadata.py
  • rg -n "python311|Python 3\.11" nix/python.nix nix/devShell.nix (no matches)
  • git diff --check

Not run: nix flake check / nix run because nix is not installed in this local environment.

Related: #9526

@RuckVibeCodes RuckVibeCodes left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[gus-first-pass] fix(nix): use python312 for package env - Simple solution, no concerns.

@OwenYWT
OwenYWT marked this pull request as ready for review April 15, 2026 02:11
@boozedog

boozedog commented Apr 16, 2026

Copy link
Copy Markdown

yes please

i have tested same fix in nix-darwin and it's working for me

@alt-glitch

Copy link
Copy Markdown
Collaborator

Superseded by #12208 (merged) which upgraded Python 3.11 → 3.12 in the Nix package and touches the same nix/python.nix and nix/devShell.nix files.

@alt-glitch alt-glitch closed this Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants