fix(nix): use python312 for package env - #9630
Closed
OwenYWT wants to merge 1 commit into
Closed
Conversation
RuckVibeCodes
left a comment
There was a problem hiding this comment.
[gus-first-pass] fix(nix): use python312 for package env - Simple solution, no concerns.
OwenYWT
marked this pull request as ready for review
April 15, 2026 02:11
|
yes please i have tested same fix in nix-darwin and it's working for me |
Collaborator
|
Superseded by #12208 (merged) which upgraded Python 3.11 → 3.12 in the Nix package and touches the same nix/python.nix and nix/devShell.nix files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
python311topython312Root cause
The current nixpkgs pin includes Sphinx 9.1, which no longer supports Python 3.11. The Nix package builder hardcoded
python311, so flake evaluation could fail whenpyproject-build-systemswired the Sphinx hook into the Python 3.11 package set.Test plan
python -m pytest -o addopts='' tests/test_nix_metadata.py -qpython -m py_compile tests/test_nix_metadata.pyrg -n "python311|Python 3\.11" nix/python.nix nix/devShell.nix(no matches)git diff --checkNot run:
nix flake check/nix runbecausenixis not installed in this local environment.Related: #9526