You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
skip Discord auto-thread creation for MessageType.reply messages
keep quote-replies in their original free-response channel so they still dispatch to the agent
read require_mention and free_response_channels from config.extra before falling back to env vars
add regression coverage for reply messages and config-backed free-response channels
Root cause
Discord reply messages can be accepted by the message filter, but _handle_message still tried to auto-create a thread for them. Reply-based conversations should stay in the original channel, and thread creation can fail for reply messages.
Your commit (95b43c17) was cherry-picked with authorship preserved — both the is_reply_message skip and the _discord_require_mention / _discord_free_response_channels helpers with config.extra fallback are in.
Thanks for the clean scope (no unrelated bundled changes), the config.extra robustness improvement (consistent with channel_skill_bindings), and the regression coverage (test_discord_reply_message_skips_auto_thread + test_discord_free_response_channel_can_come_from_config_extra). Closes #9399 along with @Hypn0sis's free-response-skip from PR #9650 — your reply-skip addressed the other half of that bug.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MessageType.replymessagesrequire_mentionandfree_response_channelsfromconfig.extrabefore falling back to env varsRoot cause
Discord reply messages can be accepted by the message filter, but
_handle_messagestill tried to auto-create a thread for them. Reply-based conversations should stay in the original channel, and thread creation can fail for reply messages.Test plan
python -m pytest -o addopts='' tests/gateway/test_discord_free_response.py tests/gateway/test_discord_channel_controls.py -qpython -m py_compile gateway/platforms/discord.py tests/gateway/test_discord_free_response.pypython -m pytest -o addopts='' tests/gateway/test_discord_system_messages.py tests/gateway/test_discord_slash_commands.py::test_auto_thread_skips_threads_and_dms -qgit diff --checkRelated: #9399