Conversation
|
Polish follow-up (author self-review): a few body sections are truncated mid-sentence and should be completed or trimmed before merge review:
|
This PR adds a well-architected Android STT bridge for the web UI, with thoughtful fallback handling between a native bridge ( A few concerns:
The review artifact ( |
3144cee to
91b5872
Compare
|
Closed C3-C6 at exact approved head |
91b5872 to
f843f20
Compare
|
Comment assumes head KEEP — Android STT bridge consumer only (after #95193)
CHECK
One-click close / ordering
Landing-evidence
|
Summary
Stack dependency
This Android follow-up now inherits the independently approved and published browser WebUI voice base at exact commit
84b4cdece0e90f627fca56ef92122a92c0d8f4c0from #95193. The Android delta is the patch-equivalent replay of the original two Android commits (ee1357982,3144ceeac) on that base, followed by the focused C4/C6 repair. Review the Android delta as84b4cdece..91b5872130; do not merge this PR before #95193 lands and this branch is rebased ontomain.Android companion contract
The concrete Android companion candidate is commit
836dd8cee870f020d3db0ce355846f9f947fe242. It installs thezer0VoiceAndroidX WebView listener with native exact-origin enforcement. The JavaScript payload remains origin-neutral and contains only protocol version, command/event names, availability mode, and transcript text; it adds no credentials or origin/auth bypass.The v1 flow requires
checkAvailability->availability->start->ready. Nativeunavailable,error, timeout, and terminal-without-final paths fall back to browser Web Speech. Partials never submit. Finals submit through the existing exactly-once PTY path.C3-C6 closure
Exact approved head:
91b5872130ace7d0946045cdcded8f6a3af5e2fe.navigator.languagerather than a hardcoded locale.speakAssistantFinalinternally guards unavailableSpeechSynthesisUtteranceand returns without synthesis.Verification
Independent review approved exact head
91b5872130ace7d0946045cdcded8f6a3af5e2fe.git diff --checkpassedEvidence boundary
No real-device or on-device-success claim is made by this PR. Physical Galaxy S25 verification remains required before publication of any such claim; this PR currently proves the WebUI contract and fallback behavior only.
Part of #94462.
Inherited reduced-motion repair
This branch is now rebuilt on approved browser base
65539bc3361faf7afca31872db38eae70754052b; exact headf843f20d9ddb7d1ac7f74e6d6fb754413cb58c76preserves the three Android-specific commits patch-equivalently with no duplicate browser fixes. The inherited listening indicator respects reduced-motion preference.Verification: focused voice/PTTY/ChatPage 4 files / 35 tests passed; full WebUI 39 files / 307 tests passed; typecheck, production build, changed-area ESLint and
git diff --checkpassed; synthetic current-main merge remained conflict-free. Independent review approved both repaired stack revisions.