fix(backup): exclude root browser-automation runtime - #95143
Open
talk2themike wants to merge 2 commits into
Open
talk2themike wants to merge 2 commits into
talk2themike wants to merge 2 commits into
Conversation
szzhoujiarui
left a comment
Contributor
There was a problem hiding this comment.
The automatic full-zip backup path in hermes_cli/backup.py:1965 still prunes every directory named browser-automation, so nested user content such as skills/example/browser-automation/README.md is omitted from create_pre_update_backup() and create_pre_migration_backup(). Please share the root-only directory-pruning logic between the manual and automatic backup walkers, and add a regression test covering nested browser-automation content in the automatic full-zip path.
talk2themike
force-pushed
the
fisk/backup-browser-automation-exclusion
branch
from
August 26, 2026 15:55
6926aa3 to
e3dd54d
Compare
Author
|
Thanks — fixed in
The PR remains scoped to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HERMES_HOME/browser-automationruntime from full backups;browser-automation;os.walkpruning.Problem
The Browser Use harness stores downloaded Chrome binaries and its live Chromium profile under
HERMES_HOME/browser-automation. Fullhermes backupcurrently descends into that regeneratable runtime because the existingbrowser-profilesexclusion does not cover this path.The runtime is large and contains live Chromium SQLite/cache files. Walking and snapshotting it can make full backups extremely slow or hang on locked databases. It should be regenerated rather than restored.
The exclusion must be root-only: user-authored nested content such as
skills/example/browser-automation/README.mdstill belongs in the backup.Verification
tests/hermes_cli/test_backup.py: 58/58 passed.git diff --check: passed.Scope
Two files only:
hermes_cli/backup.pytests/hermes_cli/test_backup.pyNo provider, network, credential, telemetry, browser runtime or unrelated backup behaviour changes.