Canonicalize OpenRouter model catalog discovery - #9474
Closed
g-guthrie wants to merge 8 commits into
Closed
Conversation
g-guthrie
marked this pull request as ready for review
April 14, 2026 08:23
19 tasks
Contributor
|
Closing as superseded by #16033. Triage notes (medium confidence): Thanks for the contribution — the underlying problem this PR addresses has been resolved by the linked PR on current main. If you believe this was closed in error, please comment and we'll reopen. (Bulk-closed during a CLI PR triage sweep.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the hand-coded OpenRouter model snapshot from Hermes and makes the OpenRouter picker/model catalog derive only from OpenRouter's live
/v1/modelsAPI.What changed
OPENROUTER_MODELSsnapshot fromhermes_cli/models.pyfetch_openrouter_models()build the catalog directly from OpenRouter's live/v1/modelsresponsemodels.devfallback so OpenRouter model discovery has a single source of truthlist_authenticated_providers()to use the dynamic OpenRouter picker catalog instead of a baked-in list/modelconsumes the discovered OpenRouter catalogWhy
The goal here is specifically to stop requiring manual source updates whenever OpenRouter adds or changes models. OpenRouter models should come from OpenRouter itself, not from a hand-maintained Hermes list or a secondary fallback source.
Testing
Ran:
/Users/gguthrie/Desktop/Hermes-Agent/venv/bin/python3.11 -m pytest -o addopts='' tests/hermes_cli/test_models.py tests/hermes_cli/test_model_switch_custom_providers.py tests/hermes_cli/test_model_validation.py tests/hermes_cli/test_opencode_go_in_model_list.py -qResult:
113 passedSupersedes