Skip to content

fix(gateway): /kanban must not raise on unbalanced quotes in args #94571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sahilvishnaliya wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −1
Open

fix(gateway): /kanban must not raise on unbalanced quotes in args #94571

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion gateway/slash_commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,7 +482,13 @@ async def _handle_kanban_command(self, event: MessageEvent) -> str:
if text.startswith("kanban"):
text = text[len("kanban"):].lstrip()

tokens = shlex.split(text) if text else []
try:
tokens = shlex.split(text) if text else []
except ValueError:
# Unbalanced quote in user-typed args ("/kanban deploy "v2)
# must not raise out of the handler — /resume guards its own
# shlex.split the same way. Fall back to whitespace splitting.
tokens = text.split()
requested_board = None
action = None
i = 0
Expand Down