fix(groups): keep active group chat rename on one group

[dokterdok]

Keep an active Group Chat reply under one name

Renaming a Bot Mode Group Chat while a Bot reply was in flight could split one
conversation into two roster rows. The room map moved to the new display name,
while the active async drive still closed over the old name and appended its
reply there.

This keeps the display name stable only while replies own the drive. The
settings dialog disables a changed name during that window, and
renameGroupChat() enforces the same invariant at the mutation boundary. Once
the drive finishes, an idle rename still moves the complete room record,
including its durable identity, sessions, stranded replies, and attention
state.

The Group Chat row context menu also opens the existing settings dialog, so
rename and picture controls are available from the place users naturally look
for them.

Note

This is now a standalone current-main recut. #93993 remains separate; no attention-marker behavior is added here.

Related work

• Tracking: Desktop Bot Mode — open bugs and issue classes (Aug 2026 sweep) #94726 is the Bot Mode umbrella tracker.
• fix(groups): hide group attention marker while open #93993 separately owns the Group Chat attention marker; it is not a prerequisite.
• fix(desktop): serialize bot group follow-ups #92041 contains a broader unresolved queueing implementation. This PR keeps
  the active-rename invariant independently reviewable and does not change
  delivery or queueing.
• fix(desktop): deliver timed-out group replies automatically #90933 owns timed-out and late reply delivery; an idle rename here preserves
  its late-reply state.
• Merged Rebuild Bot Mode on the app's design system #96726 replaced the old plugin.js surface. This head ports the same
  behavior to the typed Bot Mode modules and design-system menu.

Changes Made

• Guard renameGroupChat() while replies are active.
• Disable only a changed name during that window; picture-only saves and idle
  renames remain available.
• Add Group settings to each Group Chat row context menu.
• Localize the active-reply explanation.
• Cover active rejection, idle re-keying, late state preservation, and menu
  discovery with direct typed tests.

How to Test

1. Start a Group Chat turn whose Bot reply remains active.
2. Open Group settings and change the name: Save stays disabled, and the room
   remains under its original name.
3. Let the reply finish, then rename: the room moves once and preserves its
   identity, sessions, stranded replies, and attention state.
4. Right-click a Group Chat row and confirm Group settings opens the same
   dialog as the header settings button.

Validation

Current head f0fd3977b6 on main@245e48008f:

• Three current-main regressions failed before the fixes; 178 tests across 12 files pass afterward, without retries.
• Renderer typecheck, scoped ESLint and git diff --check pass. Every changed source/test owner is below 2,000 lines.
• Original authorship, author dates and cherry-pick provenance are preserved. Active-rename and roster-settings fixes remain separately selectable.
• No new packaged-app or live-UAT claim is made for this recut.

The pre-recut history remains on dokterdok:preserve/pr93903-before-main-refresh-20260906. No Python source changed.

[Enough1122]

AI code review — automated review for reference, author can ignore or act on any point.

Right fix at both layers: the hard guard in renameGroupChat protects every programmatic caller, the dialog disables Save with an inline reason so users learn why, and the test usefully pins that a stranded-marker room (durable state) still renames fine while a running one doesn't. Small points:

1. apps/desktop/src/plugins/hermes-bots/plugin.js:renameGroupChat — confirm the guard-to-rekey span is await-free. The blocking check runs once on entry; if anything between it and the room-map re-key ever awaits (a gateway RPC, persistence flush), a turn starting in that window re-opens the original bug. If the whole mutation section is synchronous (JS single-threaded), a one-line comment saying "no awaits between guard and re-key" would lock the invariant in for future editors; otherwise re-check running immediately before the commit.

2. plugin.js:renameBlocked uses name.trim() !== group. A case-only edit (hermes devs → Hermes Devs) counts as changed and is correctly blocked while running, but an unchanged name with stray leading/trailing whitespace typed by the user also enables the blocked state — cosmetic either way, just noting the trim asymmetry (Save still requires non-empty trimmed).

3. Nit: the new "Group settings" context-menu item rides along in this PR; it's what makes the guard discoverable, so it belongs here — worth one sentence in the PR description so reviewers don't mistake it for unrelated scope.

The source-contract regex update keeps the house-style test honest. No blocking issues.