Skip to content

fix(desktop): show a visible focus state on row-list keyboard focus #93460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
elchic00 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(desktop): show a visible focus state on row-list keyboard focus #93460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb3357a
fix(desktop): show a visible focus state on row-list keyboard focus
elchic00 Aug 24, 2026
a1de95f
fix(desktop): brighten session row title text on keyboard focus too
elchic00 Aug 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/desktop/src/app/chat/sidebar/session-row.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,7 +495,7 @@ function SidebarSessionRowImpl({
<span className="min-w-0 flex-1 self-center">
<OverflowTip label={title}>
<SidebarRowLabel
className="hover-marquee block font-normal group-hover:text-foreground group-data-[working=true]:text-foreground/90"
className="hover-marquee block font-normal group-hover:text-foreground group-has-[:focus-visible]:text-foreground group-data-[working=true]:text-foreground/90"
onPointerEnter={armMarquee}
onPointerLeave={disarmMarquee}
>
Expand Down
2 changes: 1 addition & 1 deletion apps/desktop/src/app/cron/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -935,7 +935,7 @@ function CronJobRuns({
<div className="flex flex-col gap-px">
{runs.map(run => (
<button
className="row-hover flex items-center justify-between gap-3 rounded-md px-2 py-1 text-left text-xs focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring/40"
className="row-hover flex items-center justify-between gap-3 rounded-md px-2 py-1 text-left text-xs"
key={run.id}
onClick={() => onOpenSession?.(run.id)}
type="button"
Expand Down
2 changes: 1 addition & 1 deletion apps/desktop/src/app/overlays/panel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ export function PanelListRow({
const row = (
<div
className={cn(
'group/row row-hover relative flex h-7 w-full items-center rounded-md text-[0.78rem] hover:text-foreground',
'group/row row-hover relative flex h-7 w-full items-center rounded-md text-[0.78rem] hover:text-foreground has-[:focus-visible]:text-foreground',
active ? 'bg-(--ui-row-active-background) text-foreground' : 'text-(--ui-text-secondary)'
)}
data-panel-row={rowKey}
Expand Down
4 changes: 3 additions & 1 deletion apps/desktop/src/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -985,7 +985,9 @@
color 100ms ease-out,
background-color 100ms ease-out;

&:hover {
&:hover,
&:focus-visible,
&:has(:focus-visible) {
background-color: var(--ui-row-hover-background);
transition: none;
}
Expand Down