test(gateway): guard every /stop path against session suspension - #9242
test(gateway): guard every /stop path against session suspension#9242r266-tech wants to merge 1 commit into
Conversation
Updated after the live rework: related to #9457, not a duplicate. This branch additionally covers the no-active-agent and authorized/unauthorized sibling-thread |
|
Thanks for adding a direct regression guard for the session-preservation behavior introduced by 952a885. Problems
Suggested changes
Automated hermes-sweeper review. |
4809f7f to
3277e94
Compare
|
Reworked this onto current
The branch is now a focused two-test-file diff (31 additions, one deletion). |
Related to #9457, not a duplicate after the rework: this branch additionally covers the no-active-agent and authorized/unauthorized sibling-thread |
Summary
/stopintentionally interrupts work without suspending the conversation. Thisrebases the regression guard onto current
mainand covers every current route:suspend_session()was not called;checks that the current session remains visible;
/stoppaths assert sessionpreservation.
The patch reuses the existing scenario setup instead of keeping the original
aggregate test. Related PR #9457 overlaps the three older assertions, but its
current head includes unrelated changes and does not cover the no-active or
sibling-thread paths requested in the maintainer review.
Test plan
uv run pytest -q tests/gateway/test_session_race_guard.py tests/gateway/test_stop_thread_sibling.py— 27 passeduv run ruff check tests/gateway/test_session_race_guard.py tests/gateway/test_stop_thread_sibling.pyFollow-up to #9241.