Conversation
A group message has already passed the SIGNAL_GROUP_ALLOWED_USERS intake gate before _reactions_enabled fires, so it is trusted. React even when the human sender is absent from SIGNAL_ALLOWED_USERS -- otherwise blanking the DM allowlist to deny DMs also silenced the reactions inside permitted groups.
Contributor
pacewicz
force-pushed
the
signal-group-trust
branch
from
August 22, 2026 23:40
7e40bfa to
58c77f2
Compare
Author
|
Thanks — good catch. Narrowed this PR to just the reaction gate ( |
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
_reactions_enabled(gateway/platforms/signal.py) gates the 👀/✅ reactions only on the DM allowlist (SIGNAL_ALLOWED_USERS). A group message has already passed theSIGNAL_GROUP_ALLOWED_USERSintake gate before this fires, so it is already trusted — yet blankingSIGNAL_ALLOWED_USERSto deny stranger DMs also silenced the reactions inside permitted groups.Fix
React when a group message's bare group id (
chat_id_alt) is inSIGNAL_GROUP_ALLOWED_USERS, regardless of the DM allowlist.Scope note
Narrowed to the reaction gate only. The parallel authz change (honoring
SIGNAL_GROUP_ALLOWED_USERSin_is_user_authorized) is already covered by the existing cluster — #58187 / #52240 / #44706 — so it's dropped here to avoid duplication (per the triage note).Testing
pytestsignal / reaction suites green.