Conversation
… default.tar.gz) These were committed to the repo root but are build/debug byproducts: - log.txt: empty 0-byte file - sqlite_leak_fix.png: unreferenced 832KB image - default.tar.gz: 1.96MB, only used as a test fixture OUTPUT (tests write it to a temp dir, never read from repo root) Add ignore rules so they cannot be re-committed. Part of audit cleanup (HA-D11-001 / HA-D3-001).
The module-level try/except fell back to HERMES_VERSION='0.0.0' silently. Surface the failure via the existing module logger so ACP version negotiation issues are diagnosable. Part of audit cleanup (HA-D6-001).
- AGENTS.md: convert the ui-tui dev-command block from an inline bash snippet to a numbered list (copy-paste friendly). - README.md: add AGENTS.md cross-link to the Windows install note so contributor/dev setup has a single source of truth. - secret_sources/base.py: document the deliberate shell=True exception in command_token_source (operator's own key_cmd), resolving the apparent contradiction with the no-shell rule. Part of audit cleanup (HA-D12-001 / HA-D9-001 / HA-D2-001).
Overall: worthwhile housekeeping — dropping committed binaries plus documenting the deliberate — reviewer-a · automated agent review (Hermes week-review) |
…ker image layers Follow-up to the cherry-picked cleanup: the default.tar.gz profile export was also carried into published container images by the Dockerfile's 'COPY . .' layer because .dockerignore had no matching pattern. Anchor the .gitignore rules to repo root (per review feedback on #91712) and add the same set + /*.tar.gz to .dockerignore so root archives can never reach an image layer again.
|
Thanks @EAbaracus — the artifact cleanup half of this PR was salvaged into #92394 (your commit cherry-picked with authorship preserved) and is now merged as 0cde4dd, together with .gitignore root-anchoring per the review feedback and matching .dockerignore rules so root archives can't reach Docker image layers via COPY . . again. One correction to the assessment here: default.tar.gz was not just an unreferenced test byproduct — it was a full profile export whose config.yaml contained a populated webhook secret, so the removal was security-relevant and we fast-tracked it. The credential has been handled separately. The other two commits (ACP version-import warning, AGENTS.md doc tweaks) had open review concerns (import-time logging before logging config exists; fenced-block regression), so we're not taking them as-is — feel free to reopen those as separate focused PRs if you'd like to iterate. Closing this one since the substantive fix has landed. Appreciate the audit work! |
…ker image layers Follow-up to the cherry-picked cleanup: the default.tar.gz profile export was also carried into published container images by the Dockerfile's 'COPY . .' layer because .dockerignore had no matching pattern. Anchor the .gitignore rules to repo root (per review feedback on NousResearch#91712) and add the same set + /*.tar.gz to .dockerignore so root archives can never reach an image layer again.
Summary
Small, low-risk hygiene PR (from a static read-only audit of the repo) covering 5 "good first" items:
HA-D11-001/HA-D3-001):log.txt(empty 0-byte),sqlite_leak_fix.png(832 KB, unreferenced),default.tar.gz(1.96 MB — only ever written bytests/hermes_cli/test_profiles.pyinto a temp dir, never read from repo root). Added ignore rules so they cannot be re-committed.HA-D6-001):acp_adapter/server.pyfell back toHERMES_VERSION = "0.0.0"silently on import failure; now logs a warning via the existing module logger.HA-D12-001/HA-D9-001/HA-D2-001):AGENTS.md: convert the ui-tui dev-command inline bash snippet to a numbered, copy-paste-friendly list.README.md: add anAGENTS.mdcross-link on the Windows install note so contributor/dev setup has a single source of truth.agent/secret_sources/base.py: document the deliberateshell=Trueexception incommand_token_source(operator's ownkey_cmd), resolving the apparent contradiction with the no-shell rule.Test plan
git rebase upstream/main— clean, no conflictsgit diff --stat upstream/main..shows only the intended filesupstream/main(deletion is legit cleanup, not accidental)Notes
Not security-critical; no behavioral change except the new warning log. Branch is on the
EAbaracusfork; base isNousResearch/hermes-agent@main.