fix(desktop): keep session tab strips visible - #91690
Closed
Dolverin wants to merge 1 commit into
Closed
Conversation
Session switcher zones now ignore lone-pane auto-hide and stale persisted header hiding while full-page header vetoes continue to win. The dead-end Hide header action and double-tap persistence are disabled only for chat strips; tool zones retain their existing behavior. Co-authored-by: leonphull <249432715+leonphull@users.noreply.github.com>
3 tasks
5 tasks
Collaborator
|
Right diagnosis — a session tile alone in a zone has nothing but the strip carrying its ✕. #91714 makes that a named invariant: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Keeps the Desktop session-tab strip visible for every chat switcher zone (
workspaceandsession-tile:*). Today a lone workspace auto-hides its strip, and a persistedheaderHidden: truecan make that state survive restarts. Because the only Show header action lives in the hidden strip, the user is left with no in-app recovery path.This rebased successor to #89225 keeps that navigation surface available while addressing its review feedback:
isSessionStripPaneclassifier instead of introducing a second pane-id authority;paneChrome.headerVetofor full-page views;The change is complementary to #91514 / #86278, which prevent tab double-clicks from forwarding the strip-hide gesture. This PR owns the remaining lone-workspace, persisted-state, menu, and strip-background paths.
Co-authored with and based on the policy work in #89225 by @leonphull; this branch updates the implementation to current
mainand incorporates the blocking review feedback.Related Issue
Fixes #89350
Related: #79518, #89225, #91514
Type of Change
Changes Made
renderer/lone-header.ts: centralize header visibility precedence for session vs non-session zones.renderer/tree-group.tsx: keep session strips visible, omit their dead-end hide action, and refuse persisted/double-tap hiding while preserving minimize compensation.How to Test
workspaceingrp-mainand no explicitheaderHidden; confirm the workspace tab and+remain visible.grp-main.headerHidden: true; confirm the session strip still renders and Hide header is absent from its context menu.session-tile:*zone; confirm the zone is not left minimized andheaderHidden: trueis not persisted.headerVetostill suppresses the strip.Automated verification:
vitest run --project ui src/components/pane-shell/tree: 24 files, 125 tests passed.npm run typecheck: clean.npm run lint: 0 errors (repository baseline warnings only).npm run build: production renderer + Electron bundles built successfully.git diff --check: clean.Checklist
Code
fix(scope):,feat(scope):, etc.)Documentation & Housekeeping
cli-config.yaml.exampleN/A — no config changeCONTRIBUTING.md/AGENTS.mdN/A — no architecture or workflow changeScreenshots / Logs
Live packaged Windows reproduction showed
grp-maincontaining onlyworkspacewith noheaderHidden; the left strip was absent while another session group still displayed tabs. Settinggrp-main.headerHidden = falsethrough DevTools restored the workspace tab andNew session tabaffordance immediately. The regression suite now enforces that state without requiring DevTools recovery.