fix(update): restore a Desktop build wiped by an earlier Windows update - #91193
Closed
andrexibiza wants to merge 1 commit into
Closed
fix(update): restore a Desktop build wiped by an earlier Windows update#91193andrexibiza wants to merge 1 commit into
andrexibiza wants to merge 1 commit into
Conversation
Closes the two residual NousResearch#83846 gaps left after 4aa9f73: - _rebuild_desktop_after_update gated on in-run signals only (had_desktop_app_before_update / current presence), both False for every update AFTER the run that wiped apps/desktop/release/. The HERMES_HOME desktop-build-stamp.json survives the wipe (it lives outside the checkout) and now counts as the durable 'this user had Desktop' signal. - The commit_count==0 'Already up to date!' short-circuit never reached the desktop rebuild at all, making the failure self-concealing: the version check passes forever while the app stays missing. The path now calls _rebuild_desktop_after_update; the in-process stamp check keeps it a no-op for healthy installs and users who never built Desktop return immediately.
This was referenced Aug 21, 2026
alt-glitch
added
type/bug
Collaborator
Duplicate of #87879: this is the same desktop build-stamp recovery mechanism and regression coverage, rebased onto current main. |
Contributor
Author
|
Topology correction: #87879 remains open and currently mergeable, and this PR carries the same two-file Desktop wipe-recovery surface. The rebased head here served as current-main verification, but it should not replace the original contributor's PR. I posted the exact-head validation receipt back to #87879 and am closing this duplicate. The verified rebased evidence remains linked from the canonical PR. |
22 tasks
This was referenced Aug 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the residual self-concealing recovery gap in #83846 and supersedes stale/conflicting PR #87879 while preserving its exact implementation and author identity.
After an earlier Windows ZIP-fallback/update failure deletes
apps/desktop/release/, every later update can incorrectly conclude that Desktop was never installed:This current-main rebase uses
$HERMES_HOME/desktop-build-stamp.jsonas the durable evidence that Desktop existed before the prior destructive run. The up-to-date repair path now invokes the existing Desktop rebuild owner; content-stamp checks keep the no-op path cheap, and users who never installed Desktop still do not pay for an Electron build.Provenance
This is the exact #87879 commit rebased cleanly through GitHub onto current
main; the original Git author is preserved:531e465eeafc6386ba8414d3dc652f0674c8f447Exact-head verification
All hosted workflows attached directly to
531e465e...are green:No status is inherited from #87879 or its former base.
Interlock