fix(desktop): make managed Node authoritative for Windows install scripts - #91188
Closed
andrexibiza wants to merge 1 commit into
Closed
andrexibiza wants to merge 1 commit into
andrexibiza wants to merge 1 commit into
Conversation
This was referenced Aug 21, 2026
Contributor
Author
|
Topology correction: #82355 remains open and currently mergeable, and this PR carries the same three-file managed-Node PATH surface. The rebased head here served as current-main verification, but it should not replace @fangliquanflq's original PR. I posted the exact-head validation receipt back to #82355 and am closing this duplicate. The verified rebased evidence remains linked from the canonical PR. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #82309 and supersedes stale/conflicting PR #82355 while preserving its exact implementation and original author identity.
Hermes can invoke npm through its managed Node while npm lifecycle children resolve a different, older system
nodefrom inherited PATH. Electron postinstall then fails withERR_REQUIRE_ESM, even though Hermes already provisioned a compatible runtime.This current-main rebase makes
with_hermes_node_path()authoritative:Provenance
This is the exact #82355 commit by @fangliquanflq rebased through GitHub onto current
main. The rebased commit retains @fangliquanflq as the Git author:150b197363451161308c0621385c7ca490d84108The rebase applied cleanly despite intervening
hermes_constants.pychanges; Git preserved the current file and placed the original hunk at its new location. This restores a mergeable delivery route without replacing contributor provenance.Exact-head verification
All hosted workflows attached directly to
150b1973...are green:No status is inherited from #82355 or its former base.
Scope
This closes managed-Node PATH authority for install/build subprocesses. The package-level electron-builder runtime handoff remains independently enforced by #91079; together they cover both dependency-install lifecycle children and the terminal builder wrapper. This does not claim the broader transactional deployment architecture in #88683 is complete.