fix: group-room UX — Shift+Enter newlines, open-at-latest incl. retained-pane reopen, late replies harvested (refresh #90526) - #91084
Merged
Conversation
Contributor
૮ >ﻌ< ა ci reviewran on bd6459e — fix: retained group panes re-anchor to the latest message on
|
alt-glitch
added
type/bug
teknium1
force-pushed
the
salvage/room-ux-cluster-90526
branch
from
August 20, 2026 20:54
8128e0a to
470d8cc
Compare
…latest, late replies harvested (#89884, #89835, #89545) Composer was a single-line Input (Enter always submitted, newlines impossible) — now the SDK Textarea with Enter=send / Shift+Enter=newline and popover-first key handling. Room log had no scroll anchoring (opened at position 0) — bottom sentinel + near-bottom-guarded anchor effect. Stranded replies were only harvested inside an active turn loop (stuck until the user's next send) — the settle path now runs a bounded background harvest that yields to a live loop.
Keep-alive workspace panes (#89788) stay mounted while hidden, so returning to an already-open room never remounted GroupChatWorkspace and the mount-time bottom anchor didn't rerun — reopening group A after visiting group B left A at the old scroll position. GroupChatMainView now subscribes to the pane's visibility via feature-detected host.paneVisibility (always- visible atom fallback for older SDKs) and the workspace scrolls the bottom sentinel into view on the hidden→visible edge. Repro and fix direction from the live-audit review comment on #90526. Also updates the composer shape test to slice only GroupMentionInput (GroupClarifyCard, merged since the branch was cut, legitimately uses Input) and teaches the legacy-SDK react proxy about useMemo.
teknium1
force-pushed
the
salvage/room-ux-cluster-90526
branch
from
August 20, 2026 21:15
470d8cc to
bd6459e
Compare
This was referenced Aug 20, 2026
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three group-room UX defects fixed together (refresh of #90526 onto current main), plus the retained-pane scroll gap found in that PR's live review.
Changes
GroupMentionInputrenders the SDKTextarea— Enter submits via injectedonSubmitDraft, Shift+Enter inserts a newline, the @mention popover keeps priority while open.GroupChatMainViewnow subscribes to feature-detectedhost.paneVisibility(always-visible atom fallback for older SDKs) and the workspace re-anchors on the hidden→visible edge.GroupMentionInput(GroupClarifyCard, merged since the branch was cut, legitimately usesInput); legacy-SDK react proxy learnsuseMemo; new reopen source-shape regression.Validation
line1\nline2; Enter submitted and drained the draft into the room logpaneVisibility→ always-visible fallback, previous behavior unchangedInfographic