fix(agent): handle whitespace-only input in build_plan_path - #9102
Closed
Tranquil-Flow wants to merge 1 commit into
Closed
fix(agent): handle whitespace-only input in build_plan_path#9102Tranquil-Flow wants to merge 1 commit into
Tranquil-Flow wants to merge 1 commit into
Conversation
Guard against empty splitlines() result when user_instruction contains only whitespace, falling back to the default "conversation-plan" slug instead of raising IndexError. Closes NousResearch#7576
Collaborator
Contributor
|
Thanks for the careful fix and regression tests, @Tranquil-Flow! Unfortunately this PR is no longer applicable.
Closing as the underlying code has been removed. This is an automated hermes-sweeper review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed and why
build_plan_path()crashes withIndexErrorwhenuser_instructionis whitespace-only (e.g." \n "), because.strip().splitlines()returns an empty list and[0]is applied to it.The fix splits the chained expression into two lines, guarding against the empty list before indexing.
Changes
agent/skill_commands.py: Guard emptysplitlines()result, falling back to default"conversation-plan"slugtests/agent/test_skill_commands.py: Added 3 regression tests for whitespace-only, empty string, and tab-only inputHow to test
Platform tested
Closes #7576