You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a focused current-main implementation of #85209.
Desktop and Dashboard model pickers now use exact per-model reasoning capability metadata when the serving catalog provides it, instead of always presenting Hermes' full reasoning ladder. Models without valid capability metadata retain the existing full-ladder fallback for backward compatibility.
The change intentionally excludes the unrelated sequential-tool-timeout changes that are present in PR #85246.
🐛 Bug fix (non-breaking change that fixes an issue)
✨ New feature (non-breaking change that adds functionality)
🔒 Security fix
📝 Documentation update
✅ Tests (adding or improving test coverage)
♻️ Refactor (no behavior change)
🎯 New skill (bundled or hub)
Changes Made
hermes_cli/inventory.py
Preserve valid, canonicalized supported_efforts from Nous/OpenRouter route catalogs in the model-options capability payload.
Preserve the existing fallback when capability metadata is absent or malformed.
hermes_cli/web_server.py and web/src/
Expose the same route capability data through /api/model/info and filter the Dashboard reasoning picker.
apps/desktop/src/app/shell/
Filter the main model catalog submenu to supported effort levels.
Resolve stale model presets to a deterministic supported level.
Keep none as the separate Thinking-off state.
Restore a real enabled level when turning thinking back on, including when the configured default is none.
apps/desktop/src/lib/ and web/src/lib/
Add shared filtering and fallback helpers with regression tests.
No auxiliary/submodel settings were changed.
No runtime wire clamping or Codex Multi-agent behavior was changed. Codex-specific capability discovery remains a separate follow-up; unknown Codex metadata uses the existing full-ladder fallback.
How to Test
For a model whose serving catalog exposes a restricted effort set, open the Desktop model menu and verify that only the advertised levels appear in canonical order.
Verify that Off is controlled separately and is hidden for reasoning-mandatory routes.
Switch from a model with a stale/unsupported saved effort and verify that a supported level remains selected.
Verify that a model with absent or malformed capability metadata retains the existing full ladder.
cd apps/desktop && npm run test:ui -- --run src/app/shell/model-catalog-menu.test.tsx src/app/shell/model-edit-submenu.test.tsx src/lib/reasoning-effort.test.ts
cd apps/desktop && npm run lint -- --no-warn-ignored
cd web && npm run test -- --run src/lib/reasoning-effort.test.ts
cd web && npm run typecheck
cd web && npm run lint -- --no-warn-ignored
HERMES_PYTHON=/c/hermes-data/hermes-agent/venv/Scripts/python.exe bash scripts/run_tests.sh tests/hermes_cli/test_inventory_reasoning_caps.py tests/hermes_cli/test_openrouter_reasoning_metadata.py tests/hermes_cli/test_nous_reasoning_metadata.py tests/hermes_cli/test_web_server.py
git diff --check
The full Desktop typecheck was also attempted but is currently blocked by pre-existing missing module/type declarations for blobatar/blob and blobatar/react in apps/desktop/src/sdk/index.ts; the error is outside this PR's changed files.
Related: #85246 implements the same model-capability picker behavior but bundles unrelated changes. #90801 is the focused current-main lane; maintainers should choose a canonical implementation.
Thanks @higgs1729 — this is a clean implementation of #85209, but I live-tested the premise before deciding on either PR and the catalog data can't carry it. I sent every ladder level to 7 OpenRouter models (49 calls) and compared against each model's published supported_efforts: no unlisted level was rejected anywhere, and gpt-5.4 honored the unlisted max with the most reasoning tokens of any level. Aggregators translate effort names upstream rather than reject them, so supported_efforts describes the vendor's native vocabulary, not what the route accepts; filtering the picker by it would hide levels that work. Full table in #85246. The one real failure (none on reasoning-mandatory routes) is already hidden on main via can_disable_reasoning (#90412). Closing on that evidence, same verdict as #85246 / #85209.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comp/cliCLI entry point, hermes_cli/, setup wizardcomp/dashboardWeb dashboard / control panel UI (dashboard/, landing)comp/desktopElectron desktop app (apps/desktop/*)P3Low — cosmetic, nice to havetype/bugSomething isn't working
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is a focused current-main implementation of #85209.
Desktop and Dashboard model pickers now use exact per-model reasoning capability metadata when the serving catalog provides it, instead of always presenting Hermes' full reasoning ladder. Models without valid capability metadata retain the existing full-ladder fallback for backward compatibility.
The change intentionally excludes the unrelated sequential-tool-timeout changes that are present in PR #85246.
Related Issue
Fixes #85209
Type of Change
Changes Made
hermes_cli/inventory.pysupported_effortsfrom Nous/OpenRouter route catalogs in the model-options capability payload.hermes_cli/web_server.pyandweb/src//api/model/infoand filter the Dashboard reasoning picker.apps/desktop/src/app/shell/noneas the separate Thinking-off state.none.apps/desktop/src/lib/andweb/src/lib/How to Test
Offis controlled separately and is hidden for reasoning-mandatory routes.Focused verification performed on Windows 11:
Commands included:
The full Desktop typecheck was also attempted but is currently blocked by pre-existing missing module/type declarations for
blobatar/blobandblobatar/reactinapps/desktop/src/sdk/index.ts; the error is outside this PR's changed files.Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests pass — focused tests were run instead; the full suite was not runDocumentation & Housekeeping
cli-config.yaml.exampleupdate: N/A — no config keys changedCONTRIBUTING.mdorAGENTS.mdupdate: N/A — no architecture/workflow changeScreenshots / Logs
Focused test and lint results are summarized above. No screenshot is required for this metadata/filtering change.