fix(nix): bump Python 3.11 → 3.12 to resolve sphinx 9.1.0 build failure - #9067
Closed
lopezpalacios wants to merge 1 commit into
Closed
fix(nix): bump Python 3.11 → 3.12 to resolve sphinx 9.1.0 build failure#9067lopezpalacios wants to merge 1 commit into
lopezpalacios wants to merge 1 commit into
Conversation
Collaborator
|
Likely duplicate of #12208 (merged) — same Python 3.11→3.12 bump in nix/python.nix. That fix is already on main. |
Collaborator
|
Likely duplicate of #12208 (merged). |
Contributor
|
Thanks for the contribution @lopezpalacios! This fix has already landed on Automated hermes-sweeper review found:
The sphinx 9.1.0 / Python 3.11 incompatibility you identified is a real issue and you found the right fix — it just got addressed independently. Closing as already implemented. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
nix buildfails on current main with:Sphinx 9.1.0 (pulled transitively via
pyproject-build-systems) dropped Python 3.11 support.Fix
Bump
nix/python.nixfrompython311→python312. The project'spyproject.tomlrequires>=3.11, so 3.12 is fully compatible.Tested
nix buildsucceeds onaarch64-darwin(M2 Max, macOS)hermes setup,hermes doctor, andhermes chatall work correctlyhermes doctorconfirms Python 3.12.13