Skip to content

fix(checkpoints): /rollback no longer reports "No checkpoints found" while other projects have them (#10505) - #90459

Merged
teknium1 merged 1 commit into
mainfrom
fix/rollback-all-directories-fallback
Aug 20, 2026
Merged

fix(checkpoints): /rollback no longer reports "No checkpoints found" while other projects have them (#10505)#90459
teknium1 merged 1 commit into
mainfrom
fix/rollback-all-directories-fallback

Conversation

@teknium1

Copy link
Copy Markdown
Contributor

Summary

Bare /rollback now falls back to a labeled cross-project checkpoint list instead of reporting "No checkpoints found" while checkpoints exist under another directory.

Surgical reapply of PR #10633 by @nightq (fixes #10505) onto the v2 single-store checkpoint layout — the original targeted the pre-v2 per-shadow-dir scan and no longer applied.

Reproduced live in the round-2 QA sweep: the agent's writes checkpointed the session cwd (/tmp/qa-repo, 2 fresh checkpoints), but bare /rollback searched only TERMINAL_CWD (/home/teknium) and printed "No checkpoints found for /home/teknium" — the user's undo path looked empty seconds after a write.

Changes

  • tools/checkpoint_manager.py: list_all_checkpoints() — aggregates every registered project via projects/*.json, most-recent-first, each entry carrying workdir; format_checkpoint_list() shows a [dirname] label in the all-directories view
  • hermes_cli/cli_commands_mixin.py: bare /rollback falls back to the cross-project view (with an explicit "showing all directories" notice) when the cwd project has none
  • tests/tools/test_rollback_all_directories.py: aggregation, empty-store, and label/no-label formatting contracts

Validation

Before After
bare /rollback from a cwd without checkpoints "No checkpoints found for /home/teknium" "showing all directories" + [qa-repo]-labeled list (live-verified in tmux)
targeted tests 4 passed

Original PR to close on merge: #10633 (credited author; commit reapplied rather than cherry-picked because the v2 store rewrite obsoleted the original patch base).

Infographic

rollback fallback fix infographic

@github-actions

Copy link
Copy Markdown
Contributor

૮ >ﻌ< ა ci review

ran on f0a2fa6 — fix(checkpoints): bare /rollback falls back to a labeled all

⚠️ Warnings

OSV vulnerability scan · View job

7 known vulnerabilities found in pinned dependencies.

How to fix:

Review the findings in the Security tab. Update the affected dependencies if a patched version is available.


debug info

CI timings

CI timings · View report · View job

Wall time 3m37s vs 3m56s (-8.1%). 7 job(s) slower, 16 faster, 1 unchanged.

  • OS-specific tests / macOS-only tests: -118.0s
  • OS-specific tests / Windows-only tests: -100.0s
  • OSV scan / Scan lockfiles / osv-scan: -91.0s
  • Python lints / ruff enforcement (blocking): -51.0s
  • Python tests / Run tests slice 12/12: -50.0s

@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists comp/cli CLI entry point, hermes_cli/, setup wizard comp/tools Tool registry, model_tools, toolsets sweeper:risk-session-state Sweeper risk: may lose/corrupt/mis-associate session or context state labels Aug 20, 2026
@teknium1
teknium1 merged commit fa89d87 into main Aug 20, 2026
49 checks passed
@teknium1
teknium1 deleted the fix/rollback-all-directories-fallback branch August 20, 2026 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard comp/tools Tool registry, model_tools, toolsets P2 Medium — degraded but workaround exists sweeper:risk-session-state Sweeper risk: may lose/corrupt/mis-associate session or context state type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: /rollback lists only current directory checkpoints, not all

2 participants