test(update): Windows progress self-test no longer flakes on publish/hold timing - #90371
Merged
Conversation
…tions seen in CI) test_progress_advances_while_the_orchestrator_blocks raced its subject on both edges within one hour of PR CI (#90358): - Run 1: sampled right after the shim URL printed, before the orchestrator published its stage — caught the page boot default ('Hermes will open once done.' != 'Testing quiet update'). - Run 2 (rerun): with HOLD=4s on a slow runner, the second sample slid past the hold and caught the cleared terminal state ('' != 'Testing quiet update'). Fix: wait (<=10s) for the published stage to actually land before starting the 1.5s stability window, and raise the hold to 10s so both samples land inside it. Same assertions, same contract — just anchored to the event the test is about instead of wall-clock luck.
Contributor
૮ >ﻌ< ა ci reviewran on e32d4f7 — test(update): deflake the Windows progress self-test (both r
|
alt-glitch
added
type/test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_progress_advances_while_the_orchestrator_blocksno longer flakes — it raced its subject on BOTH edges within one hour of PR CI on #90358, failing two unrelated Windows runs in a row.'Hermes will open once done.' != 'Testing quiet update').HOLD=4son a slow runner, the second sample slid past the hold → caught the cleared terminal state ('' != 'Testing quiet update').Changes
tests/test_desktop_update_windows_progress.py: wait (≤10s) for the published stage to actually land before starting the 1.5s stability window; raiseHERMES_SELFTEST_HOLD_SECONDSfrom 4 to 10 so both samples land inside the hold. Same assertions, same contract — anchored to the event under test instead of wall-clock luck. No production code touched.Validation
windows_onlyInfographic