fix(tests): use shutil.which instead of Unix 'which', skip Unix 'find' tests on Windows - #90267
Open
iamiskender wants to merge 1 commit into
Open
fix(tests): use shutil.which instead of Unix 'which', skip Unix 'find' tests on Windows#90267iamiskender wants to merge 1 commit into
iamiskender wants to merge 1 commit into
Conversation
…ix 'find' tests on Windows
Collaborator
Author
|
Ack, thanks — closing as duplicate of #42872. |
Author
|
Ack, thanks — closing as duplicate of #42872. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
tests/tools/test_search_hidden_dirs.pycollection crashed on native Windows withFileNotFoundError: [WinError 2]— theTestRipgrepAlreadyExcludesHiddenskipif condition calledsubprocess.run(["which", "rg"], ...), andwhichdoesn't exist on Windows.TestFindExcludesHiddenDirsalso relies on the Unixfindcommand viashell=True, which resolves to Windows' incompatibleFIND.EXEand fails.Fix
which-based ripgrep detection withshutil.which("rg"), which works cross-platform.TestFindExcludesHiddenDirswith@pytest.mark.skipif(sys.platform == "win32", ...)since thefind-based assertions are Unix-specific.Testing
pytest tests/tools/test_search_hidden_dirs.py -von native Windows — 8 passed, 2 skipped (previously: collection error, 0 tests ran).