fix(image-gen): Grok Imagine 2.0 catalog entry must not default upscale on - #90096
Closed
victor-kyriazakos wants to merge 1 commit into
Closed
fix(image-gen): Grok Imagine 2.0 catalog entry must not default upscale on#90096victor-kyriazakos wants to merge 1 commit into
victor-kyriazakos wants to merge 1 commit into
Conversation
…le on ceabb03 added the Grok Imagine Image 2.0 FAL catalog entry with 'upscale': True, breaking the guard test added by f06c415 (test_upscale_defaults_are_all_off) — the invariant is that NO catalog entry defaults upscaling on; it is opt-in per call because it silently multiplies cost and latency. Currently failing on main tip and on every PR whose CI slice includes tests/tools (seen on NousResearch#90038 slice 5/12). The entry's own rationale ('1k native is sub-2MP') is preserved as guidance in the comment: callers wanting print-grade output pass upscale explicitly or bump resolution to 2k.
alt-glitch
added
type/bug
Collaborator
Duplicate of #89933: both make the same one-line Grok Imagine 2.0 catalog default-upscale flip; only the explanatory comment wording differs. |
Collaborator
|
closed as dupe of merged #89933 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_upscale_defaults_are_all_offis failing on main tip (ceabb030fb) and on every open PR whose test slice includestests/tools— first noticed on #90038's slice 5/12, reproduced locally on a clean main worktree.Cause
ceabb030fb(Grok Imagine Image 2.0 FAL catalog entry) shipped with"upscale": True. The guard test added byf06c41522epins the catalog invariant: no entry defaults upscaling on — it's opt-in per call because a default silently multiplies image cost and latency.Change
One line:
upscale: True→Falseon the new entry, with the original rationale ('1k native is sub-2MP') kept as a comment steering callers to explicitupscaleor the 2kresolutiontier.Validation
tests/tools/test_image_generation.py: 51/51 locally on this branch; the single failing test reproduces on unmodified main tip.