fix(image): make Grok upscaling opt-in by default - #90084
Closed
nicha16 wants to merge 1 commit into
Closed
Conversation
The catalog-wide policy test requires upscaling to remain opt-in because automatic post-processing can degrade model-native text, faces, and fine detail. The newly added Grok Imagine 2.0 entry accidentally enabled it by default, leaving current main CI red. Align the entry with the existing policy; callers can still request upscaling explicitly.
alt-glitch
added
type/bug
Collaborator
Duplicate of #89933. The diff makes the same one-line Grok Imagine 2.0 default-upscale change. |
Contributor
Author
|
Superseded by #89933, which has now merged the same Grok Imagine 2.0 default-upscale correction. Thank you @alt-glitch for the duplicate pointer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Current
mainsets this model'supscaledefault toTrue, whileTestFalCatalog::test_upscale_defaults_are_all_offrequires automatic upscaling to remain off for every model. That contradiction makes unrelated PRs fail the shared test slice.Test plan
pytest -q tests/tools/test_image_generation.py::TestFalCatalog— 5 passed