fix(image-gen): grok-imagine-image 2.0 must not default upscale on - #90080
Closed
CocaKova wants to merge 1 commit into
Closed
fix(image-gen): grok-imagine-image 2.0 must not default upscale on#90080CocaKova wants to merge 1 commit into
CocaKova wants to merge 1 commit into
Conversation
The v2.0 catalog entry (ceabb03) shipped "upscale": True with the sub-2MP rationale — the exact default-on pattern f06c415 removed globally (opt-in per call only). TestFalCatalog:: test_upscale_defaults_are_all_off enforces that invariant, so main's test slice has been red since the entry landed. Flip the default off; callers who want the pass request it. Tests: 0 added, 51 passing in tests/tools/test_image_generation.py
alt-glitch
added
type/bug
Collaborator
Duplicate of #89933. The diff makes the same one-line Grok Imagine 2.0 default-upscale change. |
Contributor
Author
|
Confirmed — closing as a duplicate. #89933 landed the same one-line change and is merged; the Noting for anyone arriving from #90077: that PR's comment points here for the slice-12 CI failure — the actual fix is #89933, and that branch is being rebased onto post-fix main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
One line: the
xai/grok-imagine-image/v2.0FAL catalog entry defaults"upscale": True; this flips it to opt-in like every other entry.Why
f06c41522eremoved default-on upscaling globally ("opt-in only"), including the sub-2MP rationale this entry's comment revives.TestFalCatalog::test_upscale_defaults_are_all_offenforces that invariant — soPython tests / slice 12has been red on main since the v2.0 entry landed inceabb030fb(Aug 15). Every open PR currently inherits the failure.Read the original intent before flipping the other way: the invariant commit is the later, deliberate decision — the upscale pass costs an extra model call per image, which is exactly why it was made opt-in per call. Callers who want it still get it by asking.
Tests: 0 added, 51 passing in
tests/tools/test_image_generation.py